From 774e8c18e3713660a0b353345ba5c5ccc331c3b5 Mon Sep 17 00:00:00 2001 From: Dan Field Date: Tue, 15 Jan 2019 08:42:47 -0800 Subject: [PATCH] remove ignore_for_file lints (#26545) * remove ignore_for_file lints * update comments * remove example --- dev/tools/gen_date_localizations.dart | 7 ++++++- .../lib/src/l10n/date_localizations.dart | 7 +++++-- .../flutter_tools/lib/src/commands/update_packages.dart | 8 -------- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/dev/tools/gen_date_localizations.dart b/dev/tools/gen_date_localizations.dart index 1567f741971..b60ffecda66 100644 --- a/dev/tools/gen_date_localizations.dart +++ b/dev/tools/gen_date_localizations.dart @@ -81,9 +81,11 @@ Future main(List rawArgs) async { // To regenerate run (omit --overwrite to print to console instead of the file): // dart --enable-asserts dev/tools/gen_date_localizations.dart --overwrite -// ignore_for_file: public_member_api_docs ''' ); + buffer.writeln(''' +/// The subset of date symbols supported by the intl package which are also +/// supported by flutter_localizations.'''); buffer.writeln('const Map dateSymbols = {'); symbolFiles.forEach((String locale, File data) { if (materialLocales.contains(locale)) @@ -93,6 +95,9 @@ Future main(List rawArgs) async { // Code that uses datePatterns expects it to contain values of type // Map not Map. + buffer.writeln(''' +/// The subset of date patterns supported by the intl package which are also +/// supported by flutter_localizations.'''); buffer.writeln('const Map> datePatterns = > {'); patternFiles.forEach((String locale, File data) { if (materialLocales.contains(locale)) { diff --git a/packages/flutter_localizations/lib/src/l10n/date_localizations.dart b/packages/flutter_localizations/lib/src/l10n/date_localizations.dart index fcb0ec44a66..d39ae27a986 100644 --- a/packages/flutter_localizations/lib/src/l10n/date_localizations.dart +++ b/packages/flutter_localizations/lib/src/l10n/date_localizations.dart @@ -6,8 +6,8 @@ // To regenerate run (omit --overwrite to print to console instead of the file): // dart --enable-asserts dev/tools/gen_date_localizations.dart --overwrite -// ignore_for_file: public_member_api_docs - +/// The subset of date symbols supported by the intl package which are also +/// supported by flutter_localizations. const Map dateSymbols = { 'ar': { 'NAME': r'''ar''', @@ -11356,6 +11356,9 @@ const Map dateSymbols = { ], }, }; + +/// The subset of date patterns supported by the intl package which are also +/// supported by flutter_localizations. const Map> datePatterns = >{ 'ar': { diff --git a/packages/flutter_tools/lib/src/commands/update_packages.dart b/packages/flutter_tools/lib/src/commands/update_packages.dart index b0e6cadee83..73b62de99d3 100644 --- a/packages/flutter_tools/lib/src/commands/update_packages.dart +++ b/packages/flutter_tools/lib/src/commands/update_packages.dart @@ -2,8 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// ignore_for_file: flutter_style_todos - import 'dart:async'; import 'dart:collection'; @@ -22,12 +20,6 @@ import '../runner/flutter_command.dart'; /// Map from package name to package version, used to artificially pin a pub /// package version in cases when upgrading to the latest breaks Flutter. -/// -/// Example: -/// -/// ``` -/// 'linter': '0.1.35', // TODO(yjbanov): https://github.com/dart-lang/linter/issues/824 -/// ``` const Map _kManuallyPinnedDependencies = { // Add pinned packages here. 'flutter_gallery_assets': '0.1.6', // See //examples/flutter_gallery/pubspec.yaml