From 7bfbc28505a34249b0b9a66c40f7c3f93c6fe49f Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Thu, 24 Jan 2019 14:29:08 -0800 Subject: [PATCH] Revert "Upgrade the Gradle script to Android plugin version 3.3.0 (#26913)" (#27045) This reverts commit 30f33d6c7d7581e61269da8778fae59882f081d8. --- dev/benchmarks/complex_layout/android/build.gradle | 2 +- dev/benchmarks/macrobenchmarks/android/build.gradle | 2 +- dev/benchmarks/microbenchmarks/android/build.gradle | 2 +- dev/integration_tests/android_host_app/build.gradle | 2 +- .../android_semantics_testing/android/build.gradle | 2 +- .../android_views/android/build.gradle | 2 +- dev/integration_tests/channels/android/build.gradle | 2 +- .../external_ui/android/build.gradle | 2 +- dev/integration_tests/flavors/android/build.gradle | 2 +- .../named_isolates/android/build.gradle | 2 +- .../platform_interaction/android/build.gradle | 2 +- dev/integration_tests/ui/android/build.gradle | 2 +- dev/manual_tests/android/build.gradle | 2 +- examples/catalog/android/build.gradle | 2 +- examples/flutter_gallery/android/build.gradle | 2 +- examples/flutter_view/android/build.gradle | 2 +- examples/hello_world/android/build.gradle | 2 +- examples/layers/android/build.gradle | 2 +- examples/platform_channel/android/build.gradle | 2 +- examples/platform_view/android/build.gradle | 2 +- examples/stocks/android/build.gradle | 2 +- packages/flutter_tools/gradle/flutter.gradle | 11 +++++------ .../templates/app/android-java.tmpl/build.gradle | 2 +- .../templates/app/android-kotlin.tmpl/build.gradle | 4 ++-- .../plugin/android-kotlin.tmpl/build.gradle.tmpl | 2 +- 25 files changed, 30 insertions(+), 31 deletions(-) diff --git a/dev/benchmarks/complex_layout/android/build.gradle b/dev/benchmarks/complex_layout/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/dev/benchmarks/complex_layout/android/build.gradle +++ b/dev/benchmarks/complex_layout/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/dev/benchmarks/macrobenchmarks/android/build.gradle b/dev/benchmarks/macrobenchmarks/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/dev/benchmarks/macrobenchmarks/android/build.gradle +++ b/dev/benchmarks/macrobenchmarks/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/dev/benchmarks/microbenchmarks/android/build.gradle b/dev/benchmarks/microbenchmarks/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/dev/benchmarks/microbenchmarks/android/build.gradle +++ b/dev/benchmarks/microbenchmarks/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/dev/integration_tests/android_host_app/build.gradle b/dev/integration_tests/android_host_app/build.gradle index d75ee518475..e006ab47b4a 100644 --- a/dev/integration_tests/android_host_app/build.gradle +++ b/dev/integration_tests/android_host_app/build.gradle @@ -4,7 +4,7 @@ buildscript { jcenter() } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/dev/integration_tests/android_semantics_testing/android/build.gradle b/dev/integration_tests/android_semantics_testing/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/dev/integration_tests/android_semantics_testing/android/build.gradle +++ b/dev/integration_tests/android_semantics_testing/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/dev/integration_tests/android_views/android/build.gradle b/dev/integration_tests/android_views/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/dev/integration_tests/android_views/android/build.gradle +++ b/dev/integration_tests/android_views/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/dev/integration_tests/channels/android/build.gradle b/dev/integration_tests/channels/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/dev/integration_tests/channels/android/build.gradle +++ b/dev/integration_tests/channels/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/dev/integration_tests/external_ui/android/build.gradle b/dev/integration_tests/external_ui/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/dev/integration_tests/external_ui/android/build.gradle +++ b/dev/integration_tests/external_ui/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/dev/integration_tests/flavors/android/build.gradle b/dev/integration_tests/flavors/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/dev/integration_tests/flavors/android/build.gradle +++ b/dev/integration_tests/flavors/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/dev/integration_tests/named_isolates/android/build.gradle b/dev/integration_tests/named_isolates/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/dev/integration_tests/named_isolates/android/build.gradle +++ b/dev/integration_tests/named_isolates/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/dev/integration_tests/platform_interaction/android/build.gradle b/dev/integration_tests/platform_interaction/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/dev/integration_tests/platform_interaction/android/build.gradle +++ b/dev/integration_tests/platform_interaction/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/dev/integration_tests/ui/android/build.gradle b/dev/integration_tests/ui/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/dev/integration_tests/ui/android/build.gradle +++ b/dev/integration_tests/ui/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/dev/manual_tests/android/build.gradle b/dev/manual_tests/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/dev/manual_tests/android/build.gradle +++ b/dev/manual_tests/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/examples/catalog/android/build.gradle b/examples/catalog/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/examples/catalog/android/build.gradle +++ b/examples/catalog/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/examples/flutter_gallery/android/build.gradle b/examples/flutter_gallery/android/build.gradle index 112aa2a87c2..db728801d8a 100644 --- a/examples/flutter_gallery/android/build.gradle +++ b/examples/flutter_gallery/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/examples/flutter_view/android/build.gradle b/examples/flutter_view/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/examples/flutter_view/android/build.gradle +++ b/examples/flutter_view/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/examples/hello_world/android/build.gradle b/examples/hello_world/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/examples/hello_world/android/build.gradle +++ b/examples/hello_world/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/examples/layers/android/build.gradle b/examples/layers/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/examples/layers/android/build.gradle +++ b/examples/layers/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/examples/platform_channel/android/build.gradle b/examples/platform_channel/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/examples/platform_channel/android/build.gradle +++ b/examples/platform_channel/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/examples/platform_view/android/build.gradle b/examples/platform_view/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/examples/platform_view/android/build.gradle +++ b/examples/platform_view/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/examples/stocks/android/build.gradle b/examples/stocks/android/build.gradle index 541636cc492..bb8a303898c 100644 --- a/examples/stocks/android/build.gradle +++ b/examples/stocks/android/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/packages/flutter_tools/gradle/flutter.gradle b/packages/flutter_tools/gradle/flutter.gradle index 21be9191f9c..5583500a6ae 100644 --- a/packages/flutter_tools/gradle/flutter.gradle +++ b/packages/flutter_tools/gradle/flutter.gradle @@ -22,7 +22,7 @@ buildscript { jcenter() } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } @@ -421,10 +421,9 @@ class FlutterPlugin implements Plugin { } dependsOn copySharedFlutterAssetsTask } else { - Task mergeAssetsTask = variant.mergeAssetsProvider.get() - dependsOn mergeAssetsTask - dependsOn "clean${mergeAssetsTask.name.capitalize()}" - into mergeAssetsTask.outputDir + dependsOn variant.mergeAssets + dependsOn "clean${variant.mergeAssets.name.capitalize()}" + into variant.mergeAssets.outputDir } with flutterTask.assets } @@ -436,7 +435,7 @@ class FlutterPlugin implements Plugin { mergeAssets.dependsOn(copyFlutterAssetsTask) } } else { - variant.outputs[0].processResourcesProvider.get().dependsOn(copyFlutterAssetsTask) + variant.outputs[0].processResources.dependsOn(copyFlutterAssetsTask) } } if (project.android.hasProperty("applicationVariants")) { diff --git a/packages/flutter_tools/templates/app/android-java.tmpl/build.gradle b/packages/flutter_tools/templates/app/android-java.tmpl/build.gradle index 541636cc492..bb8a303898c 100644 --- a/packages/flutter_tools/templates/app/android-java.tmpl/build.gradle +++ b/packages/flutter_tools/templates/app/android-java.tmpl/build.gradle @@ -5,7 +5,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' } } diff --git a/packages/flutter_tools/templates/app/android-kotlin.tmpl/build.gradle b/packages/flutter_tools/templates/app/android-kotlin.tmpl/build.gradle index 6b2cbd7bd84..b7faad8f596 100644 --- a/packages/flutter_tools/templates/app/android-kotlin.tmpl/build.gradle +++ b/packages/flutter_tools/templates/app/android-kotlin.tmpl/build.gradle @@ -1,12 +1,12 @@ buildscript { - ext.kotlin_version = '1.3.11' + ext.kotlin_version = '1.2.71' repositories { google() jcenter() } dependencies { - classpath 'com.android.tools.build:gradle:3.3.0' + classpath 'com.android.tools.build:gradle:3.2.1' classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version" } } diff --git a/packages/flutter_tools/templates/plugin/android-kotlin.tmpl/build.gradle.tmpl b/packages/flutter_tools/templates/plugin/android-kotlin.tmpl/build.gradle.tmpl index fbe197f5aa0..9c6ca552295 100644 --- a/packages/flutter_tools/templates/plugin/android-kotlin.tmpl/build.gradle.tmpl +++ b/packages/flutter_tools/templates/plugin/android-kotlin.tmpl/build.gradle.tmpl @@ -2,7 +2,7 @@ group '{{androidIdentifier}}' version '1.0-SNAPSHOT' buildscript { - ext.kotlin_version = '1.3.11' + ext.kotlin_version = '1.2.71' repositories { google() jcenter()