From 7dd65c16c26d4650bca65ffcbecd667fa0636450 Mon Sep 17 00:00:00 2001 From: Jenn Magder Date: Wed, 5 Oct 2022 19:51:23 -0700 Subject: [PATCH] Add bitcode deprecation note for add-to-app iOS developers (#112900) --- .../bin/tasks/build_ios_framework_module_test.dart | 7 ++++++- .../lib/src/commands/build_ios_framework.dart | 4 ++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/dev/devicelab/bin/tasks/build_ios_framework_module_test.dart b/dev/devicelab/bin/tasks/build_ios_framework_module_test.dart index 1607113b205..0c03fe769b4 100644 --- a/dev/devicelab/bin/tasks/build_ios_framework_module_test.dart +++ b/dev/devicelab/bin/tasks/build_ios_framework_module_test.dart @@ -87,7 +87,8 @@ Future _testBuildIosFramework(Directory projectDir, { bool isModule = fals const String outputDirectoryName = 'flutter-frameworks'; await inDirectory(projectDir, () async { - await flutter( + final StringBuffer outputError = StringBuffer(); + await evalFlutter( 'build', options: [ 'ios-framework', @@ -96,7 +97,11 @@ Future _testBuildIosFramework(Directory projectDir, { bool isModule = fals '--obfuscate', '--split-debug-info=symbols', ], + stderr: outputError, ); + if (!outputError.toString().contains('Bitcode support has been deprecated.')) { + throw TaskResult.failure('Missing bitcode deprecation warning'); + } }); final String outputPath = path.join(projectDir.path, outputDirectoryName); diff --git a/packages/flutter_tools/lib/src/commands/build_ios_framework.dart b/packages/flutter_tools/lib/src/commands/build_ios_framework.dart index 60e81bb275d..321ef186e64 100644 --- a/packages/flutter_tools/lib/src/commands/build_ios_framework.dart +++ b/packages/flutter_tools/lib/src/commands/build_ios_framework.dart @@ -300,6 +300,10 @@ class BuildIOSFrameworkCommand extends BuildFrameworkCommand { 'See https://flutter.dev/docs/development/add-to-app/ios/add-flutter-screen#create-a-flutterengine for more information.'); } + globals.printWarning( + 'Bitcode support has been deprecated. Turn off the "Enable Bitcode" build setting in your Xcode project or you may encounter compilation errors.\n' + 'See https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes for details.'); + return FlutterCommandResult.success(); }