From 8443f7cfd348143da645ba0af937cda8f802c99d Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Wed, 27 May 2020 14:16:12 -0700 Subject: [PATCH] Revert "[flutter_tools] write test to convince self of lack of timing issue (#58011)" (#58123) This reverts commit f77c669d687c11d6aca81f053bbf028adc59794e. --- .../general.shard/resident_runner_test.dart | 42 ------------------- 1 file changed, 42 deletions(-) diff --git a/packages/flutter_tools/test/general.shard/resident_runner_test.dart b/packages/flutter_tools/test/general.shard/resident_runner_test.dart index 040ed0ef0c4..319df1a121f 100644 --- a/packages/flutter_tools/test/general.shard/resident_runner_test.dart +++ b/packages/flutter_tools/test/general.shard/resident_runner_test.dart @@ -1198,48 +1198,6 @@ void main() { }) async => mockVMService, })); - group('Timing test', () { - Completer completer; - - test('Can connect to observatory stream after receiving done event.', () => testbed.run(() async { - completer = Completer(); - fakeVmServiceHost = FakeVmServiceHost(requests: []); - final MockDevice mockDevice = MockDevice(); - final MockDeviceLogReader mockLogReader = MockDeviceLogReader(); - when(mockDevice.getLogReader(app: anyNamed('app'))).thenReturn(mockLogReader); - final StreamController controller = StreamController(); - - final TestFlutterDevice flutterDevice = TestFlutterDevice( - mockDevice, - observatoryUris: controller.stream, - ); - - final Future connectResult = flutterDevice.connect(); - - // First add the observatory URI to connect to. - controller.add(testUri); - - // Then close the stream. - await controller.close(); - - // Then complete the VM service connection. - completer.complete(mockVMService); - - await connectResult; - - verify(mockLogReader.connectedVMService = mockVMService); - }, overrides: { - VMServiceConnector: () => (Uri httpUri, { - ReloadSources reloadSources, - Restart restart, - CompileExpression compileExpression, - ReloadMethod reloadMethod, - io.CompressionOptions compression, - Device device, - }) async => completer.future, - })); - }); - test('nextPlatform moves through expected platforms', () { expect(nextPlatform('android', TestFeatureFlags()), 'iOS'); expect(nextPlatform('iOS', TestFeatureFlags()), 'fuchsia');