github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Kill compiler process when test does not exit cleanly (#34616)

Browse Source
This commit is contained in:
Jenn Magder 2019-06-18 11:24:19 -07:00 committed by GitHub
parent cc541e6724
commit 8be46a0c4a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/flutter_tools/lib/src/compile.dart
View File

@ -738,6 +738,7 @@ class ResidentCompiler {
if (_server == null) { if (_server == null) {
return 0; return 0;
} }
printTrace('killing pid ${_server.pid}');
_server.kill(); _server.kill();
return _server.exitCode; return _server.exitCode;
} }

1
packages/flutter_tools/lib/src/test/test_compiler.dart
View File

@ -85,6 +85,7 @@ class TestCompiler {
Future<void> dispose() async { Future<void> dispose() async {
await compilerController.close(); await compilerController.close();
await _shutdown();
} }
/// Create the resident compiler used to compile the test. /// Create the resident compiler used to compile the test.

9
packages/flutter_tools/test/test_compiler_test.dart
View File

@ -59,6 +59,15 @@ void main() {
expect(await testCompiler.compile('test/foo.dart'), null); expect(await testCompiler.compile('test/foo.dart'), null);
expect(fs.file('test/foo.dart.dill').existsSync(), false); expect(fs.file('test/foo.dart.dill').existsSync(), false);
verify(residentCompiler.shutdown()).called(1);
}));
test('Disposing test compiler shuts down backing compiler', () => testbed.run(() async {
testCompiler.compiler = residentCompiler;
expect(testCompiler.compilerController.isClosed, false);
await testCompiler.dispose();
expect(testCompiler.compilerController.isClosed, true);
verify(residentCompiler.shutdown()).called(1);
})); }));
}); });
} }