github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix the message strings for xcodeMissing and xcodeIncomplete (#117922)

Browse Source 
* Add macOS to xcodeMissing and xcodeIncomplete

* And unit test
This commit is contained in:
Peixin Li 2023-01-03 18:48:00 -08:00 committed by GitHub
parent 63653e8272
commit 906761cf9b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter_tools/lib/src/base/user_messages.dart
View File

@ -176,10 +176,10 @@ class UserMessages {
'Launch Xcode and install additional required components when prompted or run:\n' 'Launch Xcode and install additional required components when prompted or run:\n'
' sudo xcodebuild -runFirstLaunch'; ' sudo xcodebuild -runFirstLaunch';
String get xcodeMissing => String get xcodeMissing =>
'Xcode not installed; this is necessary for iOS development.\n' 'Xcode not installed; this is necessary for iOS and macOS development.\n'
'Download at https://developer.apple.com/xcode/download/.'; 'Download at https://developer.apple.com/xcode/download/.';
String get xcodeIncomplete => String get xcodeIncomplete =>
'Xcode installation is incomplete; a full installation is necessary for iOS development.\n' 'Xcode installation is incomplete; a full installation is necessary for iOS and macOS development.\n'
'Download at: https://developer.apple.com/xcode/download/\n' 'Download at: https://developer.apple.com/xcode/download/\n'
'Or install Xcode via the App Store.\n' 'Or install Xcode via the App Store.\n'
'Once installed, run:\n' 'Once installed, run:\n'

6
packages/flutter_tools/test/general.shard/base/user_messages_test.dart
View File

@ -30,4 +30,10 @@ void main() {
checkInstallationURL((Platform platform) => userMessages.androidSdkBuildToolsOutdated(0, '', platform)); checkInstallationURL((Platform platform) => userMessages.androidSdkBuildToolsOutdated(0, '', platform));
checkInstallationURL((Platform platform) => userMessages.androidStudioInstallation(platform)); checkInstallationURL((Platform platform) => userMessages.androidStudioInstallation(platform));
}); });
testWithoutContext('Xcode installation instructions', () {
final UserMessages userMessages = UserMessages();
expect(userMessages.xcodeMissing, contains('iOS and macOS'));
expect(userMessages.xcodeIncomplete, contains('iOS and macOS'));
});
} }