github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add versioning to gold endpoints (#66054)

Browse Source
This commit is contained in:
Kate Lovett 2020-09-18 14:47:09 -07:00 committed by GitHub
parent 8fb807a4d3
commit 9618e10a52
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_goldens/test/flutter_goldens_test.dart
View File

@ -398,7 +398,7 @@ void main() {
MockHttpClientResponse mockHttpResponse; MockHttpClientResponse mockHttpResponse;
setUp(() { setUp(() {
url = Uri.parse('https://flutter-gold.skia.org/json/ignores'); url = Uri.parse('https://flutter-gold.skia.org/json/v1/ignores');
mockHttpRequest = MockHttpClientRequest(); mockHttpRequest = MockHttpClientRequest();
mockHttpResponse = MockHttpClientResponse(utf8.encode( mockHttpResponse = MockHttpClientResponse(utf8.encode(
ignoreResponseTemplate( ignoreResponseTemplate(

2
packages/flutter_goldens/test/json_templates.dart
View File

@ -17,7 +17,7 @@ String authTemplate({
} }
/// Json response template for Skia Gold ignore request: /// Json response template for Skia Gold ignore request:
/// https://flutter-gold.skia.org/json/ignores /// https://flutter-gold.skia.org/json/v1/ignores
String ignoreResponseTemplate({ String ignoreResponseTemplate({
String pullRequestNumber = '0000', String pullRequestNumber = '0000',
String testName = 'flutter.golden_test.1', String testName = 'flutter.golden_test.1',

4
packages/flutter_goldens_client/lib/skia_client.dart
View File

@ -418,7 +418,7 @@ class SkiaGoldClient {
final String traceID = getTraceID(testName); final String traceID = getTraceID(testName);
await io.HttpOverrides.runWithHttpOverrides<Future<void>>(() async { await io.HttpOverrides.runWithHttpOverrides<Future<void>>(() async {
final Uri requestForExpectations = Uri.parse( final Uri requestForExpectations = Uri.parse(
'https://flutter-gold.skia.org/json/latestpositivedigest/$traceID' 'https://flutter-gold.skia.org/json/v1/latestpositivedigest/$traceID'
); );
late String rawResponse; late String rawResponse;
try { try {
@ -484,7 +484,7 @@ class SkiaGoldClient {
late String rawResponse; late String rawResponse;
await io.HttpOverrides.runWithHttpOverrides<Future<void>>(() async { await io.HttpOverrides.runWithHttpOverrides<Future<void>>(() async {
final Uri requestForIgnores = Uri.parse( final Uri requestForIgnores = Uri.parse(
'https://flutter-gold.skia.org/json/ignores' 'https://flutter-gold.skia.org/json/v1/ignores'
); );
try { try {