github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix boolean flag parsing in gradle. Track 'trackWidgetCreation' as property of the build. (#16901)

Browse Source
This commit is contained in:
Alexander Aprelev 2018-04-24 09:51:25 -07:00 committed by GitHub
parent c7ee37a0d8
commit a21c93dd70
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/flutter_tools/gradle/flutter.gradle
View File

@ -258,7 +258,7 @@ class FlutterPlugin implements Plugin<Project> {
Boolean previewDart2Value = false Boolean previewDart2Value = false
if (project.hasProperty('preview-dart-2')) { if (project.hasProperty('preview-dart-2')) {
previewDart2Value = project.property('preview-dart-2') previewDart2Value = project.property('preview-dart-2').toBoolean()
} }
String[] fileSystemRootsValue = null String[] fileSystemRootsValue = null
if (project.hasProperty('filesystem-roots')) { if (project.hasProperty('filesystem-roots')) {
@ -270,8 +270,9 @@ class FlutterPlugin implements Plugin<Project> {
} }
Boolean trackWidgetCreationValue = false Boolean trackWidgetCreationValue = false
if (project.hasProperty('track-widget-creation')) { if (project.hasProperty('track-widget-creation')) {
trackWidgetCreationValue = project.property('track-widget-creation') trackWidgetCreationValue = project.property('track-widget-creation').toBoolean()
} }
String extraFrontEndOptionsValue = null String extraFrontEndOptionsValue = null
if (project.hasProperty('extra-front-end-options')) { if (project.hasProperty('extra-front-end-options')) {
extraFrontEndOptionsValue = project.property('extra-front-end-options') extraFrontEndOptionsValue = project.property('extra-front-end-options')
@ -282,7 +283,7 @@ class FlutterPlugin implements Plugin<Project> {
} }
Boolean preferSharedLibraryValue = false Boolean preferSharedLibraryValue = false
if (project.hasProperty('prefer-shared-library')) { if (project.hasProperty('prefer-shared-library')) {
preferSharedLibraryValue = project.property('prefer-shared-library') preferSharedLibraryValue = project.property('prefer-shared-library').toBoolean()
} }
String targetPlatformValue = null String targetPlatformValue = null
if (project.hasProperty('target-platform')) { if (project.hasProperty('target-platform')) {

1
packages/flutter_tools/lib/src/bundle.dart
View File

@ -85,6 +85,7 @@ Future<void> build({
..add(mainPath); ..add(mainPath);
final Map<String, String> properties = <String, String>{ final Map<String, String> properties = <String, String>{
'entryPoint': mainPath, 'entryPoint': mainPath,
'trackWidgetCreation': trackWidgetCreation.toString(),
}; };
return new Fingerprint.fromBuildInputs(properties, compilerInputPaths); return new Fingerprint.fromBuildInputs(properties, compilerInputPaths);
} }