github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_tools] Don't stringify null values in EventPrinter (#76579)

Browse Source
This commit is contained in:
Jia Hao 2021-02-24 09:06:04 +08:00 committed by GitHub
parent 2d0fa57cbc
commit a341da6e0e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 41 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_tools/lib/src/test/event_printer.dart
View File

@ -22,7 +22,7 @@ class EventPrinter extends TestWatcher {
@override @override
void handleStartedDevice(Uri observatoryUri) { void handleStartedDevice(Uri observatoryUri) {
_sendEvent('test.startedProcess', _sendEvent('test.startedProcess',
<String, dynamic>{'observatoryUri': observatoryUri.toString()}); <String, dynamic>{'observatoryUri': observatoryUri?.toString()});
_parent?.handleStartedDevice(observatoryUri); _parent?.handleStartedDevice(observatoryUri);
} }

39
packages/flutter_tools/test/general.shard/test/event_printer_test.dart
View File

@ -11,16 +11,49 @@ import 'package:mockito/mockito.dart';
import '../../src/common.dart'; import '../../src/common.dart';
void main() { void main() {
testWithoutContext('EventPrinter handles a null parent', () { group(EventPrinter, () {
final EventPrinter eventPrinter = EventPrinter(out: StringBuffer());
final _Device device = _Device();
final Uri observatoryUri = Uri.parse('http://localhost:1234'); final Uri observatoryUri = Uri.parse('http://localhost:1234');
EventPrinter eventPrinter;
StringBuffer output;
setUp(() {
output = StringBuffer();
eventPrinter = EventPrinter(out: output);
});
testWithoutContext('handles a null parent', () {
final _Device device = _Device();
expect(() => eventPrinter.handleFinishedTest(device), returnsNormally); expect(() => eventPrinter.handleFinishedTest(device), returnsNormally);
expect(() => eventPrinter.handleStartedDevice(observatoryUri), returnsNormally); expect(() => eventPrinter.handleStartedDevice(observatoryUri), returnsNormally);
expect(() => eventPrinter.handleTestCrashed(device), returnsNormally); expect(() => eventPrinter.handleTestCrashed(device), returnsNormally);
expect(() => eventPrinter.handleTestTimedOut(device), returnsNormally); expect(() => eventPrinter.handleTestTimedOut(device), returnsNormally);
}); });
group('handleStartedDevice', () {
testWithoutContext('with non-null observatory', () {
eventPrinter.handleStartedDevice(observatoryUri);
expect(
output.toString(),
'\n'
'[{"event":"test.startedProcess","params":{"observatoryUri":"http://localhost:1234"}}]'
'\n',
);
});
testWithoutContext('with null observatory', () {
eventPrinter.handleStartedDevice(null);
expect(
output.toString(),
'\n'
'[{"event":"test.startedProcess","params":{"observatoryUri":null}}]'
'\n',
);
});
});
});
} }
class _Device extends Mock implements TestDevice {} class _Device extends Mock implements TestDevice {}