From a6c963032e7fc8de9873cd97ef7da42255d3e2cc Mon Sep 17 00:00:00 2001 From: Alexander Aprelev Date: Fri, 22 Dec 2017 14:39:13 -0800 Subject: [PATCH] Fix gen_snapshot name, path for Windows. Executables have '.exe' extension on Windows. We do have to specify extension for gen_snapshot since when running with local engine, we are looking for that exact file before launching it. --- packages/flutter_tools/lib/src/artifacts.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/flutter_tools/lib/src/artifacts.dart b/packages/flutter_tools/lib/src/artifacts.dart index 40f8a2065a8..e1c4991c173 100644 --- a/packages/flutter_tools/lib/src/artifacts.dart +++ b/packages/flutter_tools/lib/src/artifacts.dart @@ -33,7 +33,7 @@ String _artifactToFileName(Artifact artifact) { case Artifact.dartVmEntryPointsTxt: return 'dart_vm_entry_points.txt'; case Artifact.genSnapshot: - return 'gen_snapshot'; + return platform.isWindows ? 'gen_snapshot.exe' : 'gen_snapshot'; case Artifact.flutterTester: return 'flutter_tester'; case Artifact.snapshotDart: @@ -262,7 +262,7 @@ class LocalEngineArtifacts extends Artifacts { } String _genSnapshotPath() { - const List clangDirs = const ['clang_x86', 'clang_x64', 'clang_i386']; + const List clangDirs = const ['.', 'clang_x86', 'clang_x64', 'clang_i386']; final String genSnapshotName = _artifactToFileName(Artifact.genSnapshot); for (String clangDir in clangDirs) { final String genSnapshotPath = fs.path.join(engineOutPath, clangDir, genSnapshotName);