From a7b59b51b82ed20786ac2009d21096a9804a902c Mon Sep 17 00:00:00 2001 From: Gary Miguel Date: Mon, 23 Jul 2018 08:38:20 -0700 Subject: [PATCH] Remove redundant check for platform.isLinux. (#19441) We don't actually care if we're on linux, we care only if the lcov tool is available. We check for that explicitly just below. Additionally there is code below which indicates that lcov is available for macOS. Before this change that code would never execute. --- .../flutter_tools/lib/src/test/coverage_collector.dart | 8 -------- 1 file changed, 8 deletions(-) diff --git a/packages/flutter_tools/lib/src/test/coverage_collector.dart b/packages/flutter_tools/lib/src/test/coverage_collector.dart index de792016a0b..9eb6fce52f5 100644 --- a/packages/flutter_tools/lib/src/test/coverage_collector.dart +++ b/packages/flutter_tools/lib/src/test/coverage_collector.dart @@ -121,14 +121,6 @@ class CoverageCollector extends TestWatcher { const String baseCoverageData = 'coverage/lcov.base.info'; if (mergeCoverageData) { - if (!platform.isLinux) { - printError( - 'Merging coverage data is supported only on Linux because it ' - 'requires the "lcov" tool.' - ); - return false; - } - if (!fs.isFileSync(baseCoverageData)) { printError('Missing "$baseCoverageData". Unable to merge coverage data.'); return false;