github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add a doctor check for host executable compatibility (#8798)

Browse Source 
Fixes #6207
This commit is contained in:
John McCutchan 2017-03-15 15:22:54 -07:00 committed by GitHub
parent 2166ea5b7f
commit a80e5c20f3
1 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
packages/flutter_tools/lib/src/doctor.dart
View File

@ -9,6 +9,7 @@ import 'package:archive/archive.dart';
import 'android/android_studio_validator.dart'; import 'android/android_studio_validator.dart';
import 'android/android_workflow.dart'; import 'android/android_workflow.dart';
import 'artifacts.dart';
import 'base/common.dart'; import 'base/common.dart';
import 'base/context.dart'; import 'base/context.dart';
import 'base/file_system.dart'; import 'base/file_system.dart';
@ -67,6 +68,7 @@ class Doctor {
if (_validators == null) { if (_validators == null) {
_validators = <DoctorValidator>[]; _validators = <DoctorValidator>[];
_validators.add(new _FlutterValidator()); _validators.add(new _FlutterValidator());
_validators.add(new _HostExecutableValidator());
if (_androidWorkflow.appliesToHostPlatform) if (_androidWorkflow.appliesToHostPlatform)
_validators.add(_androidWorkflow); _validators.add(_androidWorkflow);
@ -244,6 +246,36 @@ class _FlutterValidator extends DoctorValidator {
} }
} }
class _HostExecutableValidator extends DoctorValidator {
_HostExecutableValidator() : super('Host Executable Compatibility');
bool _genSnapshotRuns(String genSnapshotPath) {
final int kExpectedExitCode = 255;
try {
return processManager.runSync(<String>[genSnapshotPath]).exitCode == kExpectedExitCode;
} catch (error) {
return false;
}
}
@override
Future<ValidationResult> validate() async {
final String genSnapshotPath =
artifacts.getArtifactPath(Artifact.genSnapshot);
final List<ValidationMessage> messages = <ValidationMessage>[];
final bool hostExecutablesRun = _genSnapshotRuns(genSnapshotPath);
final ValidationType valid = hostExecutablesRun ? ValidationType.installed : ValidationType.missing;
if (hostExecutablesRun) {
messages.add(new ValidationMessage('Downloaded executables execute on host'));
} else {
messages.add(new ValidationMessage.error(
'Downloaded executables cannot execute on host. See https://github.com/flutter/flutter/issues/6207 for more information'));
}
return new ValidationResult(valid, messages);
}
}
class NoIdeValidator extends DoctorValidator { class NoIdeValidator extends DoctorValidator {
NoIdeValidator() : super('Flutter IDE Support'); NoIdeValidator() : super('Flutter IDE Support');