github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Handle notification errors (#31868)" (#31886)

Browse Source 
This reverts commit c0d5fd23ab.
This commit is contained in:
Dan Field 2019-04-30 23:27:30 -07:00 committed by GitHub
parent c82fc132a8
commit a8504405a8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/flutter_driver/lib/src/driver/driver.dart
View File

@ -934,18 +934,9 @@ void restoreVmServiceConnectFunction() {
} }
void _unhandledJsonRpcError(dynamic error, dynamic stack) { void _unhandledJsonRpcError(dynamic error, dynamic stack) {
if (error is rpc.RpcException) {
final rpc.RpcException rpcException = error;
if (rpcException.data != null && rpcException.data['id'] == null) {
// This can happen, e.g., if a client tries to call us before methods have
// been registered, but the client doesn't care for a response.
_log.trace('RPC client sent a notification that resulted in an error:\n$error');
return;
}
assert(false, 'json_rpc_2 failed to send an exception back to the client.');
}
_log.trace('Unhandled RPC error:\n$error\n$stack'); _log.trace('Unhandled RPC error:\n$error\n$stack');
assert(false); // TODO(dnfield): https://github.com/flutter/flutter/issues/31813
// assert(false);
} }
/// Waits for a real Dart VM service to become available, then connects using /// Waits for a real Dart VM service to become available, then connects using

10
packages/flutter_tools/lib/src/vmservice.dart
View File

@ -237,16 +237,6 @@ class VMService {
} }
static void _unhandledError(dynamic error, dynamic stack) { static void _unhandledError(dynamic error, dynamic stack) {
if (error is rpc.RpcException) {
final rpc.RpcException rpcException = error;
if (rpcException.data != null && rpcException.data['id'] == null) {
// This can happen, e.g., if a client tries to call us before methods have
// been registered, but the client doesn't care for a response.
logger.printTrace('RPC client sent a notification that resulted in an error:\n$error');
return;
}
assert(false, 'json_rpc_2 failed to send an exception back to the client.');
}
logger.printTrace('Error in internal implementation of JSON RPC.\n$error\n$stack'); logger.printTrace('Error in internal implementation of JSON RPC.\n$error\n$stack');
assert(false); assert(false);
} }

8
packages/fuchsia_remote_debug_protocol/lib/src/dart/dart_vm.dart
View File

@ -33,14 +33,6 @@ RpcPeerConnectionFunction fuchsiaVmServiceConnectionFunction = _waitAndConnect;
void _unhandledJsonRpcError(dynamic error, dynamic stack) { void _unhandledJsonRpcError(dynamic error, dynamic stack) {
if (error is json_rpc.RpcException) {
final json_rpc.RpcException rpcException = error;
if (rpcException.data != null && rpcException.data['id'] == null) {
// This can happen, e.g., if a client tries to call us before methods have
// been registered, but the client doesn't care for a response.
return;
}
}
_log.fine('Error in internalimplementation of JSON RPC.\n$error\n$stack'); _log.fine('Error in internalimplementation of JSON RPC.\n$error\n$stack');
} }