github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable vm:notify-debugger-on-exception on handlePlatformMessage (#81987)

Browse Source
This commit is contained in:
Michael Goderbauer 2021-05-13 11:54:04 -07:00 committed by GitHub
parent 8eca86de9e
commit adb3f13819
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/flutter/lib/src/services/binding.dart
View File

@ -288,10 +288,7 @@ class _DefaultBinaryMessenger extends BinaryMessenger {
} }
@override @override
// TODO(goderbauer): Add pragma (and enable test in @pragma('vm:notify-debugger-on-exception')
// break_on_framework_exceptions_test.dart) when it works on async methods,
// https://github.com/dart-lang/sdk/issues/45673
// @pragma('vm:notify-debugger-on-exception')
Future<void> handlePlatformMessage( Future<void> handlePlatformMessage(
String channel, String channel,
ByteData? data, ByteData? data,

2
packages/flutter_tools/test/integration.shard/break_on_framework_exceptions_test.dart
View File

@ -122,7 +122,7 @@ void main() {
final int breakLine = (await flutter.getSourceLocation()).line; final int breakLine = (await flutter.getSourceLocation()).line;
expect(breakLine, project.lineContaining(project.test, "throw 'platform message callback';")); expect(breakLine, project.lineContaining(project.test, "throw 'platform message callback';"));
}, skip: 'TODO(goderbauer): add pragma to _DefaultBinaryMessenger.handlePlatformMessage when async methods are supported (https://github.com/dart-lang/sdk/issues/45673) and enable this test'); });
testWithoutContext('breaks when SliverChildBuilderDelegate.builder throws', () async { testWithoutContext('breaks when SliverChildBuilderDelegate.builder throws', () async {
final TestProject project = TestProject( final TestProject project = TestProject(