github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix mounted checks (#137778)

Browse Source 
Fixes in preparation for https://dart-review.googlesource.com/c/sdk/+/330561.

The change referenced above tightens the `use_build_context_synchronously` to ensure that `mounted` is checked on the appropriate `BuildContext` or `State`. This change fixes up the flutter/flutter in preparation of this new enforcement.
This commit is contained in:
Michael Goderbauer 2023-11-02 11:21:55 -07:00 committed by GitHub
parent f15f2313b9
commit b09c70a913
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dev/integration_tests/android_views/lib/motion_events_page.dart
View File

@ -175,7 +175,7 @@ class MotionEventsBodyState extends State<MotionEventsBody> {
Future<void> saveRecordedEvents(ByteData data, BuildContext context) async {
if (await channel.invokeMethod<bool>('getStoragePermission') ?? false) {
if (mounted) {
if (context.mounted) {
showMessage(context, 'External storage permissions are required to save events');
}
return;
@ -185,12 +185,12 @@ class MotionEventsBodyState extends State<MotionEventsBody> {
// This test only runs on Android so we can assume path separator is '/'.
final File file = File('${outDir?.path}/$kEventsFileName');
await file.writeAsBytes(data.buffer.asUint8List(0, data.lengthInBytes), flush: true);
if (!mounted) {
if (!context.mounted) {
return;
}
showMessage(context, 'Saved original events to ${file.path}');
} catch (e) {
if (!mounted) {
if (!context.mounted) {
return;
}
showMessage(context, 'Failed saving $e');

2
dev/integration_tests/flutter_gallery/lib/gallery/demo.dart
View File

@ -80,7 +80,7 @@ class _TabbedComponentDemoScaffoldState extends State<TabbedComponentDemoScaffol
final Uri uri = Uri.parse(url);
if (await canLaunchUrl(uri)) {
await launchUrl(uri);
} else if (mounted) {
} else if (context.mounted) {
showDialog<void>(
context: context,
builder: (BuildContext context) {

6
dev/integration_tests/hybrid_android_views/lib/motion_events_page.dart
View File

@ -157,7 +157,7 @@ class MotionEventsBodyState extends State<MotionEventsBody> {
Future<void> saveRecordedEvents(ByteData data, BuildContext context) async {
if (await channel.invokeMethod<bool>('getStoragePermission') != true) {
if (mounted) {
if (context.mounted) {
showMessage(context, 'External storage permissions are required to save events');
}
return;
@ -167,12 +167,12 @@ class MotionEventsBodyState extends State<MotionEventsBody> {
// This test only runs on Android so we can assume path separator is '/'.
final File file = File('${outDir.path}/$kEventsFileName');
await file.writeAsBytes(data.buffer.asUint8List(0, data.lengthInBytes), flush: true);
if (!mounted) {
if (!context.mounted) {
return;
}
showMessage(context, 'Saved original events to ${file.path}');
} catch (e) {
if (!mounted) {
if (!context.mounted) {
return;
}
showMessage(context, 'Failed saving $e');