github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_tools] dont let crash reporter crash tool (#66755)

Browse Source 
package:http can throw a ClientException, which the crash reporter must catch or the tool will crash in the crash reporter. 3/4 crash on dev.
This commit is contained in:
Jonah Williams 2020-09-30 15:26:25 -07:00 committed by GitHub
parent 0f90747bb3
commit b6768ec7a6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_tools/lib/src/reporting/crash_reporting.dart
View File

@ -188,7 +188,7 @@ class CrashReportSender {
// Catch all exceptions to print the message that makes clear that the // Catch all exceptions to print the message that makes clear that the
// crash logger crashed. // crash logger crashed.
} catch (sendError, sendStackTrace) { // ignore: avoid_catches_without_on_clauses } catch (sendError, sendStackTrace) { // ignore: avoid_catches_without_on_clauses
if (sendError is SocketException || sendError is HttpException) { if (sendError is SocketException || sendError is HttpException || sendError is http.ClientException) {
_logger.printError('Failed to send crash report due to a network error: $sendError'); _logger.printError('Failed to send crash report due to a network error: $sendError');
} else { } else {
// If the sender itself crashes, just print. We did our best. // If the sender itself crashes, just print. We did our best.

19
packages/flutter_tools/test/general.shard/crash_reporting_test.dart
View File

@ -183,6 +183,25 @@ void main() {
expect(logger.errorText, contains('Failed to send crash report due to a network error')); expect(logger.errorText, contains('Failed to send crash report due to a network error'));
}); });
testWithoutContext('should print an explanatory message when there is a ClientException', () async {
final CrashReportSender crashReportSender = CrashReportSender(
client: CrashingCrashReportSender(const HttpException('no internets')),
usage: mockUsage,
platform: platform,
logger: logger,
operatingSystemUtils: operatingSystemUtils,
);
await crashReportSender.sendReport(
error: ClientException('Test bad state error'),
stackTrace: null,
getFlutterVersion: () => 'test-version',
command: 'crash',
);
expect(logger.errorText, contains('Failed to send crash report due to a network error'));
});
testWithoutContext('should send only one crash report when sent many times', () async { testWithoutContext('should send only one crash report when sent many times', () async {
final RequestInfo requestInfo = RequestInfo(); final RequestInfo requestInfo = RequestInfo();