github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Build snapshots with --sync-async to match the engine. (#19495)

Browse Source 
Bug: https://github.com/flutter/flutter/issues/19494
This commit is contained in:
Ryan Macnak 2018-07-17 18:07:54 -07:00 committed by GitHub
parent 4afc9f8930
commit b8b6d4166c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_tools/lib/src/base/build.dart
View File

@ -199,6 +199,7 @@ class AOTSnapshotter {
genSnapshotArgs.addAll(<String>[
'--reify-generic-functions',
'--strong',
'--sync-async',
]);
}
if (extraGenSnapshotOptions != null && extraGenSnapshotOptions.isNotEmpty) {
@ -443,6 +444,7 @@ class CoreJITSnapshotter {
final List<String> genSnapshotArgs = <String>[
'--reify-generic-functions',
'--strong',
'--sync-async',
];
if (buildMode == BuildMode.debug) {
genSnapshotArgs.add('--enable_asserts');

14
packages/flutter_tools/test/base/build_test.dart
View File

@ -408,6 +408,7 @@ void main() {
'--embedder_entry_points_manifest=$kIoEntries',
'--reify-generic-functions',
'--strong',
'--sync-async',
'--snapshot_kind=app-aot-assembly',
'--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}',
'--no-sim-use-hardfp',
@ -454,6 +455,7 @@ void main() {
'--embedder_entry_points_manifest=$kIoEntries',
'--reify-generic-functions',
'--strong',
'--sync-async',
'--snapshot_kind=app-aot-assembly',
'--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}',
'main.dill',
@ -500,6 +502,7 @@ void main() {
'--embedder_entry_points_manifest=$kIoEntries',
'--reify-generic-functions',
'--strong',
'--sync-async',
'--snapshot_kind=app-aot-blobs',
'--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data',
@ -551,6 +554,7 @@ void main() {
'--embedder_entry_points_manifest=$kIoEntries',
'--reify-generic-functions',
'--strong',
'--sync-async',
'--snapshot_kind=app-aot-blobs',
'--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data',
@ -598,6 +602,7 @@ void main() {
'--embedder_entry_points_manifest=$kIoEntries',
'--reify-generic-functions',
'--strong',
'--sync-async',
'--snapshot_kind=app-aot-assembly',
'--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}',
'--no-sim-use-hardfp',
@ -644,6 +649,7 @@ void main() {
'--embedder_entry_points_manifest=$kIoEntries',
'--reify-generic-functions',
'--strong',
'--sync-async',
'--snapshot_kind=app-aot-assembly',
'--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}',
'main.dill',
@ -709,6 +715,7 @@ void main() {
'--embedder_entry_points_manifest=$kIoEntries',
'--reify-generic-functions',
'--strong',
'--sync-async',
'--snapshot_kind=app-aot-blobs',
'--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data',
@ -760,6 +767,7 @@ void main() {
'--embedder_entry_points_manifest=$kIoEntries',
'--reify-generic-functions',
'--strong',
'--sync-async',
'--snapshot_kind=app-aot-blobs',
'--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data',
@ -838,6 +846,7 @@ void main() {
expect(genSnapshot.additionalArgs, <String>[
'--reify-generic-functions',
'--strong',
'--sync-async',
'--enable_asserts',
'--snapshot_kind=core-jit',
'--vm_snapshot_data=build/foo/vm_snapshot_data',
@ -881,6 +890,7 @@ void main() {
expect(genSnapshot.additionalArgs, <String>[
'--reify-generic-functions',
'--strong',
'--sync-async',
'--enable_asserts',
'--snapshot_kind=core-jit',
'--vm_snapshot_data=build/foo/vm_snapshot_data',
@ -933,6 +943,7 @@ void main() {
expect(genSnapshot.additionalArgs, <String>[
'--reify-generic-functions',
'--strong',
'--sync-async',
'--snapshot_kind=core-jit',
'--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data',
@ -975,6 +986,7 @@ void main() {
expect(genSnapshot.additionalArgs, <String>[
'--reify-generic-functions',
'--strong',
'--sync-async',
'--snapshot_kind=core-jit',
'--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data',
@ -1026,6 +1038,7 @@ void main() {
expect(genSnapshot.additionalArgs, <String>[
'--reify-generic-functions',
'--strong',
'--sync-async',
'--snapshot_kind=core-jit',
'--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data',
@ -1068,6 +1081,7 @@ void main() {
expect(genSnapshot.additionalArgs, <String>[
'--reify-generic-functions',
'--strong',
'--sync-async',
'--snapshot_kind=core-jit',
'--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data',