github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_tools] ensure --track-widget-creation is not enabled for build aot (#52261)

Browse Source 
This option was defaulting to on, which was tickling some benchmarks
This commit is contained in:
Jonah Williams 2020-03-09 17:19:14 -07:00 committed by GitHub
parent 084a7077ce
commit bc43b41d99
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_tools/lib/src/commands/build.dart
View File

@ -25,7 +25,7 @@ class BuildCommand extends FlutterCommand {
addSubcommand(BuildAarCommand()); addSubcommand(BuildAarCommand());
addSubcommand(BuildApkCommand(verboseHelp: verboseHelp)); addSubcommand(BuildApkCommand(verboseHelp: verboseHelp));
addSubcommand(BuildAppBundleCommand(verboseHelp: verboseHelp)); addSubcommand(BuildAppBundleCommand(verboseHelp: verboseHelp));
addSubcommand(BuildAotCommand(verboseHelp: verboseHelp)); addSubcommand(BuildAotCommand());
addSubcommand(BuildIOSCommand()); addSubcommand(BuildIOSCommand());
addSubcommand(BuildIOSFrameworkCommand( addSubcommand(BuildIOSFrameworkCommand(
aotBuilder: AotBuilder(), aotBuilder: AotBuilder(),

6
packages/flutter_tools/lib/src/commands/build_aot.dart
View File

@ -14,7 +14,7 @@ import 'build.dart';
/// Builds AOT snapshots into platform specific library containers. /// Builds AOT snapshots into platform specific library containers.
class BuildAotCommand extends BuildSubCommand with TargetPlatformBasedDevelopmentArtifacts { class BuildAotCommand extends BuildSubCommand with TargetPlatformBasedDevelopmentArtifacts {
BuildAotCommand({bool verboseHelp = false, this.aotBuilder}) { BuildAotCommand({this.aotBuilder}) {
addTreeShakeIconsFlag(); addTreeShakeIconsFlag();
usesTargetOption(); usesTargetOption();
addBuildModeFlags(); addBuildModeFlags();
@ -51,10 +51,6 @@ class BuildAotCommand extends BuildSubCommand with TargetPlatformBasedDevelopmen
help: 'Build the AOT bundle with bitcode. Requires a compatible bitcode engine.', help: 'Build the AOT bundle with bitcode. Requires a compatible bitcode engine.',
hide: true, hide: true,
); );
// --track-widget-creation is exposed as a flag here to deal with build
// invalidation issues, but it is ignored -- there are no plans to support
// it for AOT mode.
usesTrackWidgetCreation(hasEffect: false, verboseHelp: verboseHelp);
} }
AotBuilder aotBuilder; AotBuilder aotBuilder;