From be0dde41142c07ff2f50ae565517c08a6ded9231 Mon Sep 17 00:00:00 2001 From: Alexander Aprelev Date: Thu, 18 Oct 2018 20:45:48 -0700 Subject: [PATCH] Remove optimization that was trying to bypass build process for iOS sim. (#23268) This optimization resulted in app still running with old kernel file. Fixes another source of https://github.com/flutter/flutter/issues/16604 --- packages/flutter_tools/lib/src/ios/simulators.dart | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/packages/flutter_tools/lib/src/ios/simulators.dart b/packages/flutter_tools/lib/src/ios/simulators.dart index 207e822c379..14b8dcb0b73 100644 --- a/packages/flutter_tools/lib/src/ios/simulators.dart +++ b/packages/flutter_tools/lib/src/ios/simulators.dart @@ -360,22 +360,9 @@ class IOSSimulator extends Device { } } - Future _applicationIsInstalledAndRunning(ApplicationPackage app) async { - final List criteria = await Future.wait(>[ - isAppInstalled(app), - exitsHappyAsync(['/usr/bin/killall', 'Runner']), - ]); - return criteria.reduce((bool a, bool b) => a && b); - } - Future _setupUpdatedApplicationBundle(ApplicationPackage app, BuildInfo buildInfo, String mainPath, bool usesTerminalUi) async { await _sideloadUpdatedAssetsForInstalledApplicationBundle(app, buildInfo, mainPath); - if (!await _applicationIsInstalledAndRunning(app)) - return _buildAndInstallApplicationBundle(app, buildInfo, mainPath, usesTerminalUi); - } - - Future _buildAndInstallApplicationBundle(ApplicationPackage app, BuildInfo buildInfo, String mainPath, bool usesTerminalUi) async { // Step 1: Build the Xcode project. // The build mode for the simulator is always debug.