github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use depfile with dart2wasm to determine when to rebuild. (#122817)

Browse Source 
Use depfile with dart2wasm to determine when to rebuild.
This commit is contained in:
Jackson Gardner 2023-03-16 16:13:04 -07:00 committed by GitHub
parent 245d6d45a1
commit be97d03a25
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/flutter_tools/lib/src/build_system/targets/web.dart
View File

@ -295,6 +295,7 @@ class Dart2WasmTarget extends Dart2WebTarget {
final BuildMode buildMode = getBuildModeForName(buildModeEnvironment); final BuildMode buildMode = getBuildModeForName(buildModeEnvironment);
final Artifacts artifacts = globals.artifacts!; final Artifacts artifacts = globals.artifacts!;
final File outputWasmFile = environment.buildDir.childFile('main.dart.wasm'); final File outputWasmFile = environment.buildDir.childFile('main.dart.wasm');
final File depFile = environment.buildDir.childFile('dart2wasm.d');
final String dartSdkPath = artifacts.getArtifactPath(Artifact.engineDartSdkPath, platform: TargetPlatform.web_javascript); final String dartSdkPath = artifacts.getArtifactPath(Artifact.engineDartSdkPath, platform: TargetPlatform.web_javascript);
final String dartSdkRoot = environment.fileSystem.directory(dartSdkPath).parent.path; final String dartSdkRoot = environment.fileSystem.directory(dartSdkPath).parent.path;
@ -319,10 +320,12 @@ class Dart2WasmTarget extends Dart2WebTarget {
dartSdkRoot, dartSdkRoot,
'--libraries-spec', '--libraries-spec',
artifacts.getHostArtifact(HostArtifact.flutterWebLibrariesJson).path, artifacts.getHostArtifact(HostArtifact.flutterWebLibrariesJson).path,
'--depfile=${depFile.path}',
environment.buildDir.childFile('main.dart').path, // dartfile environment.buildDir.childFile('main.dart').path, // dartfile
outputWasmFile.path, outputWasmFile.path,
]; ];
globals.printTrace('compiling dart code to wasm with command "${compilationArgs.join(' ')}"');
final ProcessResult compileResult = await globals.processManager.run(compilationArgs); final ProcessResult compileResult = await globals.processManager.run(compilationArgs);
if (compileResult.exitCode != 0) { if (compileResult.exitCode != 0) {
throw Exception(_collectOutput(compileResult)); throw Exception(_collectOutput(compileResult));
@ -335,6 +338,11 @@ class Dart2WasmTarget extends Dart2WebTarget {
@override @override
String get name => 'dart2wasm'; String get name => 'dart2wasm';
@override
List<String> get depfiles => const <String>[
'dart2wasm.d',
];
@override @override
List<Source> get outputs => const <Source>[ List<Source> get outputs => const <Source>[
Source.pattern('{OUTPUT_DIR}/main.dart.wasm'), Source.pattern('{OUTPUT_DIR}/main.dart.wasm'),

3
packages/flutter_tools/test/general.shard/build_system/targets/web_test.dart
View File

@ -778,6 +778,8 @@ void main() {
environment.defines[kBuildMode] = 'profile'; environment.defines[kBuildMode] = 'profile';
environment.defines[kDartDefines] = encodeDartDefines(<String>['FOO=bar', 'BAZ=qux']); environment.defines[kDartDefines] = encodeDartDefines(<String>['FOO=bar', 'BAZ=qux']);
final File depFile = environment.buildDir.childFile('dart2wasm.d');
processManager.addCommand(FakeCommand( processManager.addCommand(FakeCommand(
command: <String>[ command: <String>[
'bin/cache/dart-sdk/bin/dartaotruntime', 'bin/cache/dart-sdk/bin/dartaotruntime',
@ -796,6 +798,7 @@ void main() {
'bin/cache', 'bin/cache',
'--libraries-spec', '--libraries-spec',
'bin/cache/flutter_web_sdk/libraries.json', 'bin/cache/flutter_web_sdk/libraries.json',
'--depfile=${depFile.absolute.path}',
environment.buildDir.childFile('main.dart').absolute.path, environment.buildDir.childFile('main.dart').absolute.path,
environment.buildDir.childFile('main.dart.wasm').absolute.path, environment.buildDir.childFile('main.dart.wasm').absolute.path,