github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add windows_host_engine_test to presubmit, remove lint exceptions. (#162032)

Browse Source 
Closes https://github.com/flutter/flutter/issues/161990.
Closes https://github.com/flutter/flutter/issues/161406.

I don't have a Windows machine present, so will let CI tell me if it's
good to go.
This commit is contained in:
Matan Lurey 2025-01-23 08:55:40 -08:00 committed by GitHub
parent 211b46fcb1
commit c1561a41c5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 7 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/.ci.yaml
View File

@ -576,8 +576,6 @@ targets:
- name: Windows windows_host_engine_test
recipe: engine_v2/engine_v2
# TODO(matanlurey): Enable (https://github.com/flutter/flutter/issues/161990).
bringup: true
timeout: 120
properties:
config_name: windows_host_engine_test

15
engine/src/flutter/ci/builders/windows_host_engine.json
View File

@ -58,20 +58,7 @@
"flutter/build/archives:windows_flutter",
"flutter/impeller/toolkit/interop:sdk"
]
},
"tests": [
{
"language": "python3",
"name": "Host Tests for host_debug",
"script": "flutter/testing/run_tests.py",
"parameters": [
"--variant",
"ci/host_debug",
"--type",
"engine"
]
}
]
}
},
{
"archives": [

10
engine/src/flutter/ci/builders/windows_host_engine_test.json
View File

@ -16,17 +16,17 @@
},
"gn": [
"--target-dir",
"ci/host_debug",
"ci/host_debug_test",
"--runtime-mode",
"debug",
"--no-lto",
"--no-goma",
"--rbe"
],
"name": "ci\\host_debug",
"name": "ci\\host_debug_test",
"description": "Builds host-side unit tests for Windows.",
"ninja": {
"config": "ci/host_debug",
"config": "ci/host_debug_test",
"targets": [
"flutter:unittests"
]
@ -34,11 +34,11 @@
"tests": [
{
"language": "python3",
"name": "Host Tests for host_debug",
"name": "Host Tests for host_debug_test",
"script": "flutter/testing/run_tests.py",
"parameters": [
"--variant",
"ci/host_debug",
"ci/host_debug_test",
"--type",
"engine"
]

8
engine/src/flutter/tools/pkg/engine_build_configs/bin/check.dart
View File

@ -177,13 +177,7 @@ void run(
);
}
if (build.tests.isNotEmpty) {
// TODO(matanlurey): https://github.com/flutter/flutter/issues/161990.
if (target.properties.configName == 'windows_host_engine' &&
build.name == r'ci\host_debug') {
debugPrint(' Skipping: ${build.name}: Allow-listed during migration');
} else {
configConventionErrors.add('${build.name}: Includes "tests: [ ... ]"');
}
configConventionErrors.add('${build.name}: Includes "tests: [ ... ]"');
}
}
}

16
engine/src/flutter/tools/pkg/engine_build_configs/test/check_integration_test.dart
View File

@ -200,22 +200,6 @@ void main() {
expect(stderr.toString(), contains('❌ All builder files conform to release_build standards'));
});
test('allows a release builder if allow-listed', () {
addConfig('windows_host_engine', [
{
'name': r'ci\host_debug',
'archives': <Object?>[
{
'include_paths': ['out/foo'],
},
],
'tests': <Object?>[{}],
},
], releaseBuild: true);
run(['--engine-src-path=${tmpFlutterEngineSrc.path}']);
});
test('fails if archives.include_paths is empty', () {
addConfig('linux_engine', [
{