mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
Add windows_host_engine_test
to presubmit, remove lint exceptions. (#162032)
Closes https://github.com/flutter/flutter/issues/161990. Closes https://github.com/flutter/flutter/issues/161406. I don't have a Windows machine present, so will let CI tell me if it's good to go.
This commit is contained in:
parent
211b46fcb1
commit
c1561a41c5
@ -576,8 +576,6 @@ targets:
|
|||||||
|
|
||||||
- name: Windows windows_host_engine_test
|
- name: Windows windows_host_engine_test
|
||||||
recipe: engine_v2/engine_v2
|
recipe: engine_v2/engine_v2
|
||||||
# TODO(matanlurey): Enable (https://github.com/flutter/flutter/issues/161990).
|
|
||||||
bringup: true
|
|
||||||
timeout: 120
|
timeout: 120
|
||||||
properties:
|
properties:
|
||||||
config_name: windows_host_engine_test
|
config_name: windows_host_engine_test
|
||||||
|
@ -58,20 +58,7 @@
|
|||||||
"flutter/build/archives:windows_flutter",
|
"flutter/build/archives:windows_flutter",
|
||||||
"flutter/impeller/toolkit/interop:sdk"
|
"flutter/impeller/toolkit/interop:sdk"
|
||||||
]
|
]
|
||||||
},
|
|
||||||
"tests": [
|
|
||||||
{
|
|
||||||
"language": "python3",
|
|
||||||
"name": "Host Tests for host_debug",
|
|
||||||
"script": "flutter/testing/run_tests.py",
|
|
||||||
"parameters": [
|
|
||||||
"--variant",
|
|
||||||
"ci/host_debug",
|
|
||||||
"--type",
|
|
||||||
"engine"
|
|
||||||
]
|
|
||||||
}
|
}
|
||||||
]
|
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"archives": [
|
"archives": [
|
||||||
|
@ -16,17 +16,17 @@
|
|||||||
},
|
},
|
||||||
"gn": [
|
"gn": [
|
||||||
"--target-dir",
|
"--target-dir",
|
||||||
"ci/host_debug",
|
"ci/host_debug_test",
|
||||||
"--runtime-mode",
|
"--runtime-mode",
|
||||||
"debug",
|
"debug",
|
||||||
"--no-lto",
|
"--no-lto",
|
||||||
"--no-goma",
|
"--no-goma",
|
||||||
"--rbe"
|
"--rbe"
|
||||||
],
|
],
|
||||||
"name": "ci\\host_debug",
|
"name": "ci\\host_debug_test",
|
||||||
"description": "Builds host-side unit tests for Windows.",
|
"description": "Builds host-side unit tests for Windows.",
|
||||||
"ninja": {
|
"ninja": {
|
||||||
"config": "ci/host_debug",
|
"config": "ci/host_debug_test",
|
||||||
"targets": [
|
"targets": [
|
||||||
"flutter:unittests"
|
"flutter:unittests"
|
||||||
]
|
]
|
||||||
@ -34,11 +34,11 @@
|
|||||||
"tests": [
|
"tests": [
|
||||||
{
|
{
|
||||||
"language": "python3",
|
"language": "python3",
|
||||||
"name": "Host Tests for host_debug",
|
"name": "Host Tests for host_debug_test",
|
||||||
"script": "flutter/testing/run_tests.py",
|
"script": "flutter/testing/run_tests.py",
|
||||||
"parameters": [
|
"parameters": [
|
||||||
"--variant",
|
"--variant",
|
||||||
"ci/host_debug",
|
"ci/host_debug_test",
|
||||||
"--type",
|
"--type",
|
||||||
"engine"
|
"engine"
|
||||||
]
|
]
|
||||||
|
@ -177,16 +177,10 @@ void run(
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
if (build.tests.isNotEmpty) {
|
if (build.tests.isNotEmpty) {
|
||||||
// TODO(matanlurey): https://github.com/flutter/flutter/issues/161990.
|
|
||||||
if (target.properties.configName == 'windows_host_engine' &&
|
|
||||||
build.name == r'ci\host_debug') {
|
|
||||||
debugPrint(' Skipping: ${build.name}: Allow-listed during migration');
|
|
||||||
} else {
|
|
||||||
configConventionErrors.add('${build.name}: Includes "tests: [ ... ]"');
|
configConventionErrors.add('${build.name}: Includes "tests: [ ... ]"');
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
|
||||||
|
|
||||||
if (configConventionErrors.isNotEmpty) {
|
if (configConventionErrors.isNotEmpty) {
|
||||||
buildConventionErrors.add(
|
buildConventionErrors.add(
|
||||||
|
@ -200,22 +200,6 @@ void main() {
|
|||||||
expect(stderr.toString(), contains('❌ All builder files conform to release_build standards'));
|
expect(stderr.toString(), contains('❌ All builder files conform to release_build standards'));
|
||||||
});
|
});
|
||||||
|
|
||||||
test('allows a release builder if allow-listed', () {
|
|
||||||
addConfig('windows_host_engine', [
|
|
||||||
{
|
|
||||||
'name': r'ci\host_debug',
|
|
||||||
'archives': <Object?>[
|
|
||||||
{
|
|
||||||
'include_paths': ['out/foo'],
|
|
||||||
},
|
|
||||||
],
|
|
||||||
'tests': <Object?>[{}],
|
|
||||||
},
|
|
||||||
], releaseBuild: true);
|
|
||||||
|
|
||||||
run(['--engine-src-path=${tmpFlutterEngineSrc.path}']);
|
|
||||||
});
|
|
||||||
|
|
||||||
test('fails if archives.include_paths is empty', () {
|
test('fails if archives.include_paths is empty', () {
|
||||||
addConfig('linux_engine', [
|
addConfig('linux_engine', [
|
||||||
{
|
{
|
||||||
|
Loading…
Reference in New Issue
Block a user