github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Include stdout in codesign failure output (#115115)

Browse Source
This commit is contained in:
Jenn Magder 2022-11-10 14:09:20 -08:00 committed by GitHub
parent 1f891a0f33
commit c1ceda41ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/flutter_tools/lib/src/build_system/targets/ios.dart
View File

@ -711,6 +711,16 @@ void _signFramework(Environment environment, String binaryPath, BuildMode buildM
binaryPath,
]);
if (result.exitCode != 0) {
throw Exception('Failed to codesign $binaryPath with identity $codesignIdentity.\n${result.stderr}');
final String stdout = (result.stdout as String).trim();
final String stderr = (result.stderr as String).trim();
final StringBuffer output = StringBuffer();
output.writeln('Failed to codesign $binaryPath with identity $codesignIdentity.');
if (stdout.isNotEmpty) {
output.writeln(stdout);
}
if (stderr.isNotEmpty) {
output.writeln(stderr);
}
throw Exception(output.toString());
}
}

20
packages/flutter_tools/test/general.shard/build_system/targets/ios_test.dart
View File

@ -836,13 +836,17 @@ void main() {
lipoCommandNonFatResult,
lipoVerifyArm64Command,
FakeCommand(command: <String>[
'codesign',
'--force',
'--sign',
'ABC123',
'--timestamp=none',
binary.path,
], exitCode: 1, stderr: 'codesign error'),
'codesign',
'--force',
'--sign',
'ABC123',
'--timestamp=none',
binary.path,
],
exitCode: 1,
stderr: 'codesign error',
stdout: 'codesign info',
),
]);
await expectLater(
@ -850,7 +854,7 @@ void main() {
throwsA(isException.having(
(Exception exception) => exception.toString(),
'description',
contains('Failed to codesign output/Flutter.framework/Flutter with identity ABC123.\ncodesign error'),
contains('Failed to codesign output/Flutter.framework/Flutter with identity ABC123.\ncodesign info\ncodesign error'),
)),
);