github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak in BottomNavigationBar (#146748)

Browse Source
This commit is contained in:
Valentin Vignal 2024-04-16 22:53:27 +08:00 committed by GitHub
parent cb719db814
commit c3445dc190
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter/lib/src/material/bottom_navigation_bar.dart
View File

@ -883,6 +883,9 @@ class _BottomNavigationBarState extends State<BottomNavigationBar> with TickerPr
for (final _Circle circle in _circles) {
circle.dispose();
}
for (final CurvedAnimation animation in _animations) {
animation.dispose();
}
super.dispose();
}

6
packages/flutter/test/material/bottom_sheet_test.dart
View File

@ -7,6 +7,7 @@ import 'dart:ui';
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
import '../widgets/semantics_tester.dart';
@ -1282,7 +1283,10 @@ void main() {
await checkDragHandleAndColors();
});
testWidgets('showModalBottomSheet does not use root Navigator by default', (WidgetTester tester) async {
testWidgets('showModalBottomSheet does not use root Navigator by default',
// TODO(polina-c): remove when fixed https://github.com/flutter/flutter/issues/145600 [leak-tracking-opt-in]
experimentalLeakTesting: LeakTesting.settings.withTracked(classes: const <String>['CurvedAnimation']),
(WidgetTester tester) async {
await tester.pumpWidget(MaterialApp(
home: Scaffold(
body: Navigator(onGenerateRoute: (RouteSettings settings) => MaterialPageRoute<void>(builder: (_) {