github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Xcode 13 as minimum recommended version (#90906)

Browse Source
This commit is contained in:
Jenn Magder 2021-09-30 12:23:55 -07:00 committed by GitHub
parent afd84ad425
commit c48c428e46
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_tools/lib/src/macos/xcode.dart
View File

@ -22,7 +22,7 @@ Version get xcodeRequiredVersion => Version(12, 0, 1, text: '12.0.1');
/// Diverging this number from the minimum required version will provide a doctor /// Diverging this number from the minimum required version will provide a doctor
/// warning, not error, that users should upgrade Xcode. /// warning, not error, that users should upgrade Xcode.
Version get xcodeRecommendedVersion => xcodeRequiredVersion; Version get xcodeRecommendedVersion => Version(13, 0, 0, text: '13.0.0');
/// SDK name passed to `xcrun --sdk`. Corresponds to undocumented Xcode /// SDK name passed to `xcrun --sdk`. Corresponds to undocumented Xcode
/// SUPPORTED_PLATFORMS values. /// SUPPORTED_PLATFORMS values.

8
packages/flutter_tools/test/general.shard/macos/xcode_test.dart
View File

@ -189,28 +189,28 @@ void main() {
testWithoutContext('isRecommendedVersionSatisfactory is true when version meets minimum', () { testWithoutContext('isRecommendedVersionSatisfactory is true when version meets minimum', () {
xcodeProjectInterpreter.isInstalled = true; xcodeProjectInterpreter.isInstalled = true;
xcodeProjectInterpreter.version = Version(12, 0, 1); xcodeProjectInterpreter.version = Version(13, 0, 0);
expect(xcode.isRecommendedVersionSatisfactory, isTrue); expect(xcode.isRecommendedVersionSatisfactory, isTrue);
}); });
testWithoutContext('isRecommendedVersionSatisfactory is true when major version exceeds minimum', () { testWithoutContext('isRecommendedVersionSatisfactory is true when major version exceeds minimum', () {
xcodeProjectInterpreter.isInstalled = true; xcodeProjectInterpreter.isInstalled = true;
xcodeProjectInterpreter.version = Version(13, 0, 0); xcodeProjectInterpreter.version = Version(14, 0, 0);
expect(xcode.isRecommendedVersionSatisfactory, isTrue); expect(xcode.isRecommendedVersionSatisfactory, isTrue);
}); });
testWithoutContext('isRecommendedVersionSatisfactory is true when minor version exceeds minimum', () { testWithoutContext('isRecommendedVersionSatisfactory is true when minor version exceeds minimum', () {
xcodeProjectInterpreter.isInstalled = true; xcodeProjectInterpreter.isInstalled = true;
xcodeProjectInterpreter.version = Version(12, 3, 0); xcodeProjectInterpreter.version = Version(13, 3, 0);
expect(xcode.isRecommendedVersionSatisfactory, isTrue); expect(xcode.isRecommendedVersionSatisfactory, isTrue);
}); });
testWithoutContext('isRecommendedVersionSatisfactory is true when patch version exceeds minimum', () { testWithoutContext('isRecommendedVersionSatisfactory is true when patch version exceeds minimum', () {
xcodeProjectInterpreter.isInstalled = true; xcodeProjectInterpreter.isInstalled = true;
xcodeProjectInterpreter.version = Version(12, 0, 2); xcodeProjectInterpreter.version = Version(13, 0, 2);
expect(xcode.isRecommendedVersionSatisfactory, isTrue); expect(xcode.isRecommendedVersionSatisfactory, isTrue);
}); });

4
packages/flutter_tools/test/general.shard/macos/xcode_validator_test.dart
View File

@ -69,8 +69,8 @@ void main() {
final ValidationResult result = await validator.validate(); final ValidationResult result = await validator.validate();
expect(result.type, ValidationType.partial); expect(result.type, ValidationType.partial);
expect(result.messages.last.type, ValidationMessageType.hint); expect(result.messages.last.type, ValidationMessageType.hint);
expect(result.messages.last.message, contains('Flutter recommends a minimum Xcode version of 12.0.2')); expect(result.messages.last.message, contains('Flutter recommends a minimum Xcode version of 13.0.0'));
}, skip: true); // [intended] Unskip and update when minimum and required check versions diverge. });
testWithoutContext('Emits partial status when Xcode EULA not signed', () async { testWithoutContext('Emits partial status when Xcode EULA not signed', () async {
final ProcessManager processManager = FakeProcessManager.list(<FakeCommand>[ final ProcessManager processManager = FakeProcessManager.list(<FakeCommand>[