github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ignore stdout in WindowsTest.LaunchMainHasNoOutput (#167583)

Browse Source 
The stdout stream may receive expected output printed by Dart
(specifically the message announcing the URL where the Dart VM service
is listening)

See https://github.com/flutter/flutter/issues/167418
This commit is contained in:
Jason Simmons 2025-04-22 21:57:46 +00:00 committed by GitHub
parent 127faefdf2
commit cddd4acaca
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
engine/src/flutter/shell/platform/windows/flutter_windows_unittests.cc
View File

@ -82,8 +82,8 @@ TEST_F(WindowsTest, LaunchMain) {
// Verify there is no unexpected output from launching main. // Verify there is no unexpected output from launching main.
TEST_F(WindowsTest, LaunchMainHasNoOutput) { TEST_F(WindowsTest, LaunchMainHasNoOutput) {
// Replace stdout & stderr stream buffers with our own. // Replace stderr stream buffer with our own. (stdout may contain expected
StreamCapture stdout_capture(&std::cout); // output printed by Dart, such as the Dart VM service startup message)
StreamCapture stderr_capture(&std::cerr); StreamCapture stderr_capture(&std::cerr);
auto& context = GetContext(); auto& context = GetContext();
@ -91,11 +91,9 @@ TEST_F(WindowsTest, LaunchMainHasNoOutput) {
ViewControllerPtr controller{builder.Run()}; ViewControllerPtr controller{builder.Run()};
ASSERT_NE(controller, nullptr); ASSERT_NE(controller, nullptr);
stdout_capture.Stop();
stderr_capture.Stop(); stderr_capture.Stop();
// Verify stdout & stderr have no output. // Verify stderr has no output.
EXPECT_TRUE(stdout_capture.GetOutput().empty());
EXPECT_TRUE(stderr_capture.GetOutput().empty()); EXPECT_TRUE(stderr_capture.GetOutput().empty());
} }