github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add more information to cannot find Chrome message (#41695)

Browse Source
This commit is contained in:
Jonah Williams 2019-10-01 14:03:12 -07:00 committed by GitHub
parent 5e1f600fe7
commit ce2c708a90
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter_tools/lib/src/web/web_validator.dart
View File

@ -22,7 +22,8 @@ class WebValidator extends DoctorValidator {
ValidationMessage('$kChromeEnvironment = $chrome') ValidationMessage('$kChromeEnvironment = $chrome')
else else
if (!canRunChrome) if (!canRunChrome)
ValidationMessage.hint('$kChromeEnvironment not set') ValidationMessage.hint('Cannot find Chrome. Try setting '
'$kChromeEnvironment to a Chrome executable.')
else else
ValidationMessage('Chrome at $chrome'), ValidationMessage('Chrome at $chrome'),
]; ];

2
packages/flutter_tools/test/general.shard/web/web_validator_test.dart
View File

@ -50,7 +50,7 @@ void main() {
when(mockProcessManager.canRun(kMacOSExecutable)).thenReturn(false); when(mockProcessManager.canRun(kMacOSExecutable)).thenReturn(false);
final ValidationResult result = await webValidator.validate(); final ValidationResult result = await webValidator.validate();
expect(result.messages, <ValidationMessage>[ expect(result.messages, <ValidationMessage>[
ValidationMessage.hint('CHROME_EXECUTABLE not set'), ValidationMessage.hint('Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.'),
]); ]);
expect(result.type, ValidationType.missing); expect(result.type, ValidationType.missing);
})); }));