github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added vscode-insiders path installed via snap (#137117)

Browse Source 
Closes  #137116

<b>Before</b>
VS Code Insiders installed via Snap isn't detected.

<b>After</b>
```sh
[✓] VS Code (version 1.84.0-insider)
    • VS Code at /snap/code-insiders/current/usr/share/code-insiders
    • Flutter extension version 3.75.20231002
```
This commit is contained in:
Kristijan Žic 2023-12-01 21:40:49 +01:00 committed by GitHub
parent 7d9010c357
commit cf71a55f7d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/flutter_tools/lib/src/vscode/vscode.dart
View File

@ -240,6 +240,7 @@ class VsCode {
// /usr/share/code/bin/code // /usr/share/code/bin/code
// /snap/code/current/usr/share/code // /snap/code/current/usr/share/code
// /usr/share/code-insiders/bin/code-insiders // /usr/share/code-insiders/bin/code-insiders
// /snap/code-insiders/current/usr/share/code-insiders
// Linux Extensions: // Linux Extensions:
// $HOME/.vscode/extensions // $HOME/.vscode/extensions
// $HOME/.vscode-insiders/extensions // $HOME/.vscode-insiders/extensions
@ -251,6 +252,10 @@ class VsCode {
'/usr/share/code-insiders', '/usr/share/code-insiders',
'.vscode-insiders', '.vscode-insiders',
), ),
const VsCodeInstallLocation(
'/snap/code-insiders/current/usr/share/code-insiders',
'.vscode-insiders',
),
], fileSystem, platform); ], fileSystem, platform);
} }

3
packages/flutter_tools/test/general.shard/vscode/vscode_test.dart
View File

@ -46,11 +46,12 @@ void main() {
final Platform platform = FakePlatform(environment: <String, String>{'HOME': home}); final Platform platform = FakePlatform(environment: <String, String>{'HOME': home});
fileSystem.directory(fileSystem.path.join('/snap/code/current/usr/share/code', '.vscode')).createSync(recursive: true); fileSystem.directory(fileSystem.path.join('/snap/code/current/usr/share/code', '.vscode')).createSync(recursive: true);
fileSystem.directory(fileSystem.path.join('/snap/code-insiders/current/usr/share/code-insiders', '.vscode-insiders')).createSync(recursive: true);
final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[]); final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[]);
final List<VsCode> installed = VsCode.allInstalled(fileSystem, platform, processManager); final List<VsCode> installed = VsCode.allInstalled(fileSystem, platform, processManager);
expect(installed.length, 1); expect(installed.length, 2);
}); });
testWithoutContext('can locate installations on macOS', () { testWithoutContext('can locate installations on macOS', () {