mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
[raw_menu_anchor.0.dart] Remove misdrawn emojis. (#162807)
This PR removes the leading emojis displayed on the RawMenuAnchor example. I knew emojis usually showed up monochrome on web, but code samples also appear to incorrectly display the emoji source. Because this change doesn't affect the menu's functionality, I didn't include additional tests, but I'd be happy to add tests if needed. One test was modified to account for menu items no longer having a leading icon. <img width="1247" alt="image" src="https://github.com/user-attachments/assets/58a338c8-c882-4ad1-af44-596d91e9f382" /> Fixes https://github.com/flutter/flutter/issues/162806 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Tirth <pateltirth454@gmail.com>
This commit is contained in:
parent
2d30cae396
commit
d48820528c
@ -12,14 +12,13 @@ void main() {
|
||||
}
|
||||
|
||||
enum Animal {
|
||||
cat('Cat', leading: Text('🦁')),
|
||||
kitten('Kitten', leading: Text('🐱')),
|
||||
felisCatus('Felis catus', leading: Text('🐈')),
|
||||
dog('Dog', leading: Text('🐕'));
|
||||
cat('Cat'),
|
||||
kitten('Kitten'),
|
||||
felisCatus('Felis catus'),
|
||||
dog('Dog');
|
||||
|
||||
const Animal(this.label, {this.leading});
|
||||
const Animal(this.label);
|
||||
final String label;
|
||||
final Widget? leading;
|
||||
}
|
||||
|
||||
class RawMenuAnchorExample extends StatefulWidget {
|
||||
@ -81,7 +80,6 @@ class _RawMenuAnchorExampleState extends State<RawMenuAnchorExample> {
|
||||
});
|
||||
controller.close();
|
||||
},
|
||||
leadingIcon: SizedBox(width: 24, child: Center(child: animal.leading)),
|
||||
trailingIcon:
|
||||
_selectedAnimal == animal ? const Icon(Icons.check, size: 20) : null,
|
||||
child: Text(animal.label),
|
||||
|
@ -27,7 +27,7 @@ void main() {
|
||||
expect(find.text(dogLabel), findsOneWidget);
|
||||
expect(
|
||||
tester.getRect(find.ancestor(of: find.text(catLabel), matching: find.byType(TapRegion))),
|
||||
rectMoreOrLessEquals(const Rect.fromLTRB(447.2, 328.0, 662.3, 532.0), epsilon: 0.1),
|
||||
rectMoreOrLessEquals(const Rect.fromLTRB(447.2, 328.0, 626.3, 532.0), epsilon: 0.1),
|
||||
);
|
||||
|
||||
// Close the menu.
|
||||
@ -90,7 +90,7 @@ void main() {
|
||||
|
||||
expect(
|
||||
tester.getRect(find.ancestor(of: find.text(catLabel), matching: find.byType(TapRegion))),
|
||||
rectMoreOrLessEquals(const Rect.fromLTRB(447.2, 328.0, 662.3, 532.0), epsilon: 0.1),
|
||||
rectMoreOrLessEquals(const Rect.fromLTRB(447.2, 328.0, 626.3, 532.0), epsilon: 0.1),
|
||||
);
|
||||
|
||||
expect(
|
||||
|
Loading…
Reference in New Issue
Block a user