github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

[web] skip debug mode CanvasKit e2e tests due to flakiness; unskip all other modes (#147736)

Browse Source 
- Skip debug mode CanvasKit e2e tests due to flakiness.
- Unskip all other modes (`text_editing_integration` was over-skipped).

Fixes https://github.com/flutter/flutter/issues/146189
This commit is contained in:
Yegor 2024-05-02 15:23:30 -07:00 committed by GitHub
parent 5d1bfdcb87
commit d5836ee60c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
dev/bots/suite_runners/run_web_tests.dart
View File

@ -152,10 +152,9 @@ class WebTestsSuite {
// This test doesn't do anything interesting w.r.t. rendering, so we don't run the full build mode x renderer matrix. // This test doesn't do anything interesting w.r.t. rendering, so we don't run the full build mode x renderer matrix.
// These tests have been extremely flaky, so we are temporarily disabling them until we figure out how to make them more robust. // These tests have been extremely flaky, so we are temporarily disabling them until we figure out how to make them more robust.
// See https://github.com/flutter/flutter/issues/143834 () => _runWebE2eTest('text_editing_integration', buildMode: 'debug', renderer: 'canvaskit'),
// () => _runWebE2eTest('text_editing_integration', buildMode: 'debug', renderer: 'canvaskit'), () => _runWebE2eTest('text_editing_integration', buildMode: 'profile', renderer: 'html'),
// () => _runWebE2eTest('text_editing_integration', buildMode: 'profile', renderer: 'html'), () => _runWebE2eTest('text_editing_integration', buildMode: 'release', renderer: 'html'),
// () => _runWebE2eTest('text_editing_integration', buildMode: 'release', renderer: 'html'),
// This test doesn't do anything interesting w.r.t. rendering, so we don't run the full build mode x renderer matrix. // This test doesn't do anything interesting w.r.t. rendering, so we don't run the full build mode x renderer matrix.
() => _runWebE2eTest('url_strategy_integration', buildMode: 'debug', renderer: 'html'), () => _runWebE2eTest('url_strategy_integration', buildMode: 'debug', renderer: 'html'),
@ -293,6 +292,11 @@ class WebTestsSuite {
bool expectWriteResponseFile = false, bool expectWriteResponseFile = false,
String expectResponseFileContent = '', String expectResponseFileContent = '',
}) async { }) async {
// TODO(yjbanov): this is temporarily disabled due to https://github.com/flutter/flutter/issues/147731
if (buildMode == 'debug' && renderer == 'canvaskit') {
print('SKIPPED: $target in debug CanvasKit mode due to https://github.com/flutter/flutter/issues/147731');
return;
}
printProgress('${green}Running integration tests $target in $buildMode mode.$reset'); printProgress('${green}Running integration tests $target in $buildMode mode.$reset');
await runCommand( await runCommand(
flutter, flutter,
@ -421,6 +425,11 @@ class WebTestsSuite {
/// The test is written using `package:integration_test` (despite the "e2e" in /// The test is written using `package:integration_test` (despite the "e2e" in
/// the name, which is there for historic reasons). /// the name, which is there for historic reasons).
Future<void> _runGalleryE2eWebTest(String buildMode, { bool canvasKit = false }) async { Future<void> _runGalleryE2eWebTest(String buildMode, { bool canvasKit = false }) async {
// TODO(yjbanov): this is temporarily disabled due to https://github.com/flutter/flutter/issues/147731
if (buildMode == 'debug' && canvasKit) {
print('SKIPPED: Gallery e2e web test in debug CanvasKit mode due to https://github.com/flutter/flutter/issues/147731');
return;
}
printProgress('${green}Running flutter_gallery integration test in --$buildMode using ${canvasKit ? 'CanvasKit' : 'HTML'} renderer.$reset'); printProgress('${green}Running flutter_gallery integration test in --$buildMode using ${canvasKit ? 'CanvasKit' : 'HTML'} renderer.$reset');
final String testAppDirectory = path.join(flutterRoot, 'dev', 'integration_tests', 'flutter_gallery'); final String testAppDirectory = path.join(flutterRoot, 'dev', 'integration_tests', 'flutter_gallery');
await runCommand( await runCommand(