fix: Call codec.dispose in flutter/test (#161127)

PR derived from https://github.com/flutter/flutter/pull/159945.

Added `codec.dispose()` for directories under `flutter/test`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This commit is contained in:
Koji Wakamiya 2025-01-24 00:13:40 +09:00 committed by GitHub
parent 11a15cb525
commit d59995bac3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 1 deletions

View File

@ -30,7 +30,9 @@ class FakeCodec implements ui.Codec {
for (int i = 0; i < frameCount; i += 1) {
frameInfos.add(await codec.getNextFrame());
}
return FakeCodec._(frameCount, codec.repetitionCount, frameInfos);
final int repetitionCount = codec.repetitionCount;
codec.dispose();
return FakeCodec._(frameCount, repetitionCount, frameInfos);
}
@override

View File

@ -126,6 +126,7 @@ Future<void> testImageQuality(WidgetTester tester, ui.FilterQuality? quality) as
final ui.Image image =
(await tester.runAsync(() async {
final ui.Codec codec = await ui.instantiateImageCodec(test3x3Image);
addTearDown(codec.dispose);
return (await codec.getNextFrame()).image;
}))!;
addTearDown(image.dispose);

View File

@ -4717,6 +4717,7 @@ class _TestWidgetInspectorService extends TestWidgetInspectorService {
base64.decode(base64Screenshot),
);
final ui.FrameInfo frame = await codec.getNextFrame();
codec.dispose();
return frame.image;
}))!;
addTearDown(screenshotImage.dispose);