github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_tools] Enable fast start by default for Android (#48746)

Browse Source
This commit is contained in:
Jonah Williams 2020-01-14 12:38:53 -08:00 committed by GitHub
parent b9733522dd
commit d5b0b3c8d1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
packages/flutter_tools/lib/src/commands/run.dart
View File

@ -189,8 +189,7 @@ class RunCommand extends RunCommandBase {
)
..addFlag('fast-start',
negatable: true,
defaultsTo: false,
hide: true,
defaultsTo: true,
help: 'Whether to quickly bootstrap applications with a minimal app. '
'Currently this is only supported on Android devices. This option '
'cannot be paired with --use-application-binary.'
@ -319,10 +318,6 @@ class RunCommand extends RunCommandBase {
await super.validateCommand();
}
if (boolArg('fast-start') && runningWithPrebuiltApplication) {
throwToolExit('--fast-start is not supported with --use-application-binary');
}
devices = await findAllTargetDevices();
if (devices == null) {
throwToolExit(null);
@ -365,7 +360,9 @@ class RunCommand extends RunCommandBase {
vmserviceOutFile: stringArg('vmservice-out-file'),
// Allow forcing fast-start to off to prevent doing more work on devices that
// don't support it.
fastStart: boolArg('fast-start') && devices.every((Device device) => device.supportsFastStart),
fastStart: boolArg('fast-start')
&& !runningWithPrebuiltApplication
&& devices.every((Device device) => device.supportsFastStart),
);
}
}
@ -428,12 +425,6 @@ class RunCommand extends RunCommandBase {
}
for (final Device device in devices) {
if (!device.supportsFastStart && boolArg('fast-start')) {
globals.printStatus(
'Using --fast-start option with device ${device.name}, but this device '
'does not support it. Overriding the setting to false.'
);
}
if (await device.isLocalEmulator) {
if (await device.supportsHardwareRendering) {
final bool enableSoftwareRendering = boolArg('enable-software-rendering') == true;

6
packages/flutter_tools/test/commands.shard/hermetic/run_test.dart
View File

@ -77,7 +77,7 @@ void main() {
]);
fail('Expect exception');
} catch (e) {
expect(e.toString(), contains('--fast-start is not supported with --use-application-binary'));
expect(e.toString(), isNot(contains('--fast-start is not supported with --use-application-binary')));
}
}, overrides: <Type, Generator>{
FileSystem: () => MemoryFileSystem(),
@ -115,10 +115,10 @@ void main() {
}
final BufferLogger bufferLogger = globals.logger as BufferLogger;
expect(bufferLogger.statusText, contains(
expect(bufferLogger.statusText, isNot(contains(
'Using --fast-start option with device mockdevice, but this device '
'does not support it. Overriding the setting to false.'
));
)));
}, overrides: <Type, Generator>{
FileSystem: () => MemoryFileSystem(),
ProcessManager: () => FakeProcessManager.any(),