github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use Mountain View/Cupertino terms in drawer on iOS (#12699)

Browse Source 
Use our platform identifiers rather than OS names for the platform
switcher radio buttons in the drawer as noted in section 2.3.10 of the
App Store review guidelines.

See: https://developer.apple.com/app-store/review/guidelines/
This commit is contained in:
Chris Bracken 2017-10-24 18:11:10 -07:00 committed by GitHub
parent 021a268852
commit d69fcea1a8
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
examples/flutter_gallery/lib/gallery/drawer.dart
View File

@ -171,7 +171,7 @@ class GalleryDrawer extends StatelessWidget {
final Widget mountainViewItem = new RadioListTile<TargetPlatform>( final Widget mountainViewItem = new RadioListTile<TargetPlatform>(
// on iOS, we don't want to show an Android phone icon // on iOS, we don't want to show an Android phone icon
secondary: new Icon(defaultTargetPlatform == TargetPlatform.iOS ? Icons.star : Icons.phone_android), secondary: new Icon(defaultTargetPlatform == TargetPlatform.iOS ? Icons.star : Icons.phone_android),
title: const Text('Android'), title: new Text(defaultTargetPlatform == TargetPlatform.iOS ? 'Mountain View' : 'Android'),
value: TargetPlatform.android, value: TargetPlatform.android,
groupValue: Theme.of(context).platform, groupValue: Theme.of(context).platform,
onChanged: onPlatformChanged, onChanged: onPlatformChanged,
@ -181,7 +181,7 @@ class GalleryDrawer extends StatelessWidget {
final Widget cupertinoItem = new RadioListTile<TargetPlatform>( final Widget cupertinoItem = new RadioListTile<TargetPlatform>(
// on iOS, we don't want to show the iPhone icon // on iOS, we don't want to show the iPhone icon
secondary: new Icon(defaultTargetPlatform == TargetPlatform.iOS ? Icons.star_border : Icons.phone_iphone), secondary: new Icon(defaultTargetPlatform == TargetPlatform.iOS ? Icons.star_border : Icons.phone_iphone),
title: const Text('iOS'), title: new Text(defaultTargetPlatform == TargetPlatform.iOS ? 'Cupertino' : 'iOS'),
value: TargetPlatform.iOS, value: TargetPlatform.iOS,
groupValue: Theme.of(context).platform, groupValue: Theme.of(context).platform,
onChanged: onPlatformChanged, onChanged: onPlatformChanged,
@ -238,11 +238,12 @@ class GalleryDrawer extends StatelessWidget {
children: <TextSpan>[ children: <TextSpan>[
new TextSpan( new TextSpan(
style: aboutTextStyle, style: aboutTextStyle,
text: 'Flutter is an early-stage, open-source project to help ' text: 'Flutter is an early-stage, open-source project to help developers'
'developers build high-performance, high-fidelity, mobile ' 'build high-performance, high-fidelity, mobile apps for '
'apps for iOS and Android from a single codebase. This ' '${defaultTargetPlatform == TargetPlatform.iOS ? 'multiple platforms' : 'iOS and Android'} '
"gallery is a preview of Flutter's many widgets, behaviors, " 'from a single codebase. This gallery is a preview of '
'animations, layouts, and more. Learn more about Flutter at ' "Flutter's many widgets, behaviors, animations, layouts, "
'and more. Learn more about Flutter at '
), ),
new LinkTextSpan( new LinkTextSpan(
style: linkStyle, style: linkStyle,