github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix GLFW GN rule to add missing Mac dependencies. (#533)

Browse Source 
Not including CoreVideo and IOKit here yields linker errors when the
final executable is linked. This required executable targets that have
no knowledge of CoreVideo or IOKit explicitly specify a dependency.

With this change, these dependencies will be implicitly added if the
target depends on GLFW.

The suppression -Wno-objc-multiple-method-names is necessary after
updating GLFW to the latest (which landing this patch will unblock).
This commit is contained in:
Chinmay Garde 2021-12-06 14:43:28 -08:00 committed by GitHub
parent 492b605144
commit db6d037a77
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
build/secondary/third_party/glfw/BUILD.gn vendored
View File

@ -93,7 +93,15 @@ source_set("glfw") {
defines = [ "_GLFW_COCOA" ] defines = [ "_GLFW_COCOA" ]
cflags = [ "-Wno-deprecated-declarations" ] cflags = [
"-Wno-deprecated-declarations",
"-Wno-objc-multiple-method-names",
]
frameworks = [
"CoreVideo.framework",
"IOKit.framework",
]
} }
configs -= [ "//build/config/compiler:chromium_code" ] configs -= [ "//build/config/compiler:chromium_code" ]