From dbddcf26b53417b7149c6ea21ca585c35aba6275 Mon Sep 17 00:00:00 2001 From: Siva Date: Thu, 12 Apr 2018 14:24:10 -0700 Subject: [PATCH] Turn off unused changes report during hot reload (#16520) * A new UI is being designed to make the unused reload messaging clearer, the UI will use the coverage data to highlight lines in the UI that were not executed during a reload. In lieu of that we are turning off the unused reload messages experiment. There were some issues in Dart2 also with this functionality - source fingerprinting is not implemented in Dart2 - some additional synthetic functions are generated for invocation argument checking that are not appropriately filtered out. --- packages/flutter_tools/lib/src/run_hot.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/flutter_tools/lib/src/run_hot.dart b/packages/flutter_tools/lib/src/run_hot.dart index a84f3e0bcb5..7abd754fe8c 100644 --- a/packages/flutter_tools/lib/src/run_hot.dart +++ b/packages/flutter_tools/lib/src/run_hot.dart @@ -500,6 +500,7 @@ class HotRunner extends ResidentRunner { // change from host path to a device path). Subsequent reloads will // not be affected, so we resume reporting reload times on the second // reload. + final bool reportUnused = !debuggingOptions.buildInfo.previewDart2; final bool shouldReportReloadTime = !_runningFromSnapshot; final Stopwatch reloadTimer = new Stopwatch()..start(); @@ -660,7 +661,7 @@ class HotRunner extends ResidentRunner { flutterUsage.sendTiming('hot', 'reload', reloadTimer.elapsed); String unusedElementMessage; - if (!reassembleAndScheduleErrors && !reassembleTimedOut) { + if (reportUnused && !reassembleAndScheduleErrors && !reassembleTimedOut) { final List>> unusedReports = >>[]; for (FlutterDevice device in flutterDevices)