github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

_NoOpCodec review feedback (#149442)

Browse Source
This commit is contained in:
Kevin Moore 2024-05-31 14:03:27 -07:00 committed by GitHub
parent 86321ed229
commit dd2d123806
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 22 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter/test/painting/image_provider_network_image_test.dart
View File

@ -13,7 +13,7 @@ import 'package:flutter_test/flutter_test.dart';
import '../image_data.dart'; import '../image_data.dart';
import '../rendering/rendering_tester.dart'; import '../rendering/rendering_tester.dart';
import 'noop_codec.dart'; import 'no_op_codec.dart';
void main() { void main() {
TestRenderingFlutterBinding.ensureInitialized(); TestRenderingFlutterBinding.ensureInitialized();
@ -242,7 +242,7 @@ void main() {
const NetworkImage provider = NetworkImage(url); const NetworkImage provider = NetworkImage(url);
final MultiFrameImageStreamCompleter completer = provider.loadBuffer(provider, noopCodec) as MultiFrameImageStreamCompleter; final MultiFrameImageStreamCompleter completer = provider.loadBuffer(provider, noOpDecoderBufferCallback) as MultiFrameImageStreamCompleter;
expect(completer.debugLabel, url); expect(completer.debugLabel, url);
}); });

12
packages/flutter/test/painting/image_provider_test.dart
View File

@ -15,7 +15,7 @@ import 'package:flutter_test/flutter_test.dart';
import '../image_data.dart'; import '../image_data.dart';
import '../rendering/rendering_tester.dart'; import '../rendering/rendering_tester.dart';
import 'mocks_for_image_cache.dart'; import 'mocks_for_image_cache.dart';
import 'noop_codec.dart'; import 'no_op_codec.dart';
void main() { void main() {
TestRenderingFlutterBinding.ensureInitialized(); TestRenderingFlutterBinding.ensureInitialized();
@ -89,7 +89,7 @@ void main() {
final FileImage provider = FileImage(file); final FileImage provider = FileImage(file);
expect(provider.loadBuffer(provider, (ImmutableBuffer buffer, {int? cacheWidth, int? cacheHeight, bool? allowUpscaling}) async { expect(provider.loadBuffer(provider, (ImmutableBuffer buffer, {int? cacheWidth, int? cacheHeight, bool? allowUpscaling}) async {
return Future<Codec>.value(NoopCodec()); return Future<Codec>.value(createNoOpCodec());
}), isA<MultiFrameImageStreamCompleter>()); }), isA<MultiFrameImageStreamCompleter>());
expect(await error.future, isStateError); expect(await error.future, isStateError);
@ -100,7 +100,7 @@ void main() {
final File file = fs.file('/blue.png')..createSync(recursive: true)..writeAsBytesSync(kBlueSquarePng); final File file = fs.file('/blue.png')..createSync(recursive: true)..writeAsBytesSync(kBlueSquarePng);
final FileImage provider = FileImage(file); final FileImage provider = FileImage(file);
final MultiFrameImageStreamCompleter completer = provider.loadBuffer(provider, noopCodec) as MultiFrameImageStreamCompleter; final MultiFrameImageStreamCompleter completer = provider.loadBuffer(provider, noOpDecoderBufferCallback) as MultiFrameImageStreamCompleter;
expect(completer.debugLabel, file.path); expect(completer.debugLabel, file.path);
}); });
@ -109,7 +109,7 @@ void main() {
final Uint8List bytes = Uint8List.fromList(kBlueSquarePng); final Uint8List bytes = Uint8List.fromList(kBlueSquarePng);
final MemoryImage provider = MemoryImage(bytes); final MemoryImage provider = MemoryImage(bytes);
final MultiFrameImageStreamCompleter completer = provider.loadBuffer(provider, noopCodec) as MultiFrameImageStreamCompleter; final MultiFrameImageStreamCompleter completer = provider.loadBuffer(provider, noOpDecoderBufferCallback) as MultiFrameImageStreamCompleter;
expect(completer.debugLabel, 'MemoryImage(${describeIdentity(bytes)})'); expect(completer.debugLabel, 'MemoryImage(${describeIdentity(bytes)})');
}); });
@ -118,7 +118,7 @@ void main() {
const String asset = 'images/blue.png'; const String asset = 'images/blue.png';
final ExactAssetImage provider = ExactAssetImage(asset, bundle: _TestAssetBundle()); final ExactAssetImage provider = ExactAssetImage(asset, bundle: _TestAssetBundle());
final AssetBundleImageKey key = await provider.obtainKey(ImageConfiguration.empty); final AssetBundleImageKey key = await provider.obtainKey(ImageConfiguration.empty);
final MultiFrameImageStreamCompleter completer = provider.loadBuffer(key, noopCodec) as MultiFrameImageStreamCompleter; final MultiFrameImageStreamCompleter completer = provider.loadBuffer(key, noOpDecoderBufferCallback) as MultiFrameImageStreamCompleter;
expect(completer.debugLabel, asset); expect(completer.debugLabel, asset);
}); });
@ -128,7 +128,7 @@ void main() {
final ResizeImage provider = ResizeImage(MemoryImage(bytes), width: 40, height: 40); final ResizeImage provider = ResizeImage(MemoryImage(bytes), width: 40, height: 40);
final MultiFrameImageStreamCompleter completer = provider.loadBuffer( final MultiFrameImageStreamCompleter completer = provider.loadBuffer(
await provider.obtainKey(ImageConfiguration.empty), await provider.obtainKey(ImageConfiguration.empty),
noopCodec, noOpDecoderBufferCallback,
) as MultiFrameImageStreamCompleter; ) as MultiFrameImageStreamCompleter;
expect(completer.debugLabel, 'MemoryImage(${describeIdentity(bytes)}) - Resized(40×40)'); expect(completer.debugLabel, 'MemoryImage(${describeIdentity(bytes)}) - Resized(40×40)');

23
packages/flutter/test/painting/noop_codec.dart → packages/flutter/test/painting/no_op_codec.dart
View File

@ -4,7 +4,20 @@
import 'dart:ui'; import 'dart:ui';
class NoopCodec implements Codec { /// Returns a [Codec] that throws on all member invocations.
Codec createNoOpCodec() => _NoOpCodec();
/// Function matching [DecoderBufferCallback] which returns a [Codec]
/// that throws on all member invocations.
Future<Codec> noOpDecoderBufferCallback(
ImmutableBuffer buffer, {
int? cacheWidth,
int? cacheHeight,
bool? allowUpscaling,
}) async =>
_NoOpCodec();
class _NoOpCodec implements Codec {
@override @override
void dispose() {} void dispose() {}
@ -17,11 +30,3 @@ class NoopCodec implements Codec {
@override @override
int get repetitionCount => throw UnimplementedError(); int get repetitionCount => throw UnimplementedError();
} }
Future<Codec> noopCodec(
ImmutableBuffer buffer, {
int? cacheWidth,
int? cacheHeight,
bool? allowUpscaling,
}) async =>
NoopCodec();