github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

nest list views for bad scroll (#110373)

Browse Source
This commit is contained in:
Jonah Williams 2022-08-26 15:10:24 -07:00 committed by GitHub
parent 056f11060f
commit e36e9ca0e2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
dev/benchmarks/complex_layout/lib/src/app.dart
View File

@ -90,7 +90,23 @@ class ComplexLayout extends StatefulWidget {
class ComplexLayoutState extends State<ComplexLayout> { class ComplexLayoutState extends State<ComplexLayout> {
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
print(widget.badScroll); Widget body = ListView.builder(
key: const Key('complex-scroll'), // this key is used by the driver test
controller: ScrollController(), // So that the scroll offset can be tracked
itemCount: widget.badScroll ? 500 : null,
shrinkWrap: widget.badScroll,
itemBuilder: (BuildContext context, int index) {
if (index.isEven) {
return FancyImageItem(index, key: PageStorageKey<int>(index));
} else {
return FancyGalleryItem(index, key: PageStorageKey<int>(index));
}
},
);
if (widget.badScroll) {
body = ListView(children: <Widget>[body]);
}
return Scaffold( return Scaffold(
appBar: AppBar( appBar: AppBar(
title: const Text('Advanced Layout'), title: const Text('Advanced Layout'),
@ -107,21 +123,7 @@ class ComplexLayoutState extends State<ComplexLayout> {
), ),
body: Column( body: Column(
children: <Widget>[ children: <Widget>[
Expanded( Expanded(child: body),
child: ListView.builder(
key: const Key('complex-scroll'), // this key is used by the driver test
controller: ScrollController(), // So that the scroll offset can be tracked
itemCount: widget.badScroll ? 500 : null,
shrinkWrap: widget.badScroll,
itemBuilder: (BuildContext context, int index) {
if (index.isEven) {
return FancyImageItem(index, key: PageStorageKey<int>(index));
} else {
return FancyGalleryItem(index, key: PageStorageKey<int>(index));
}
},
),
),
const BottomBar(), const BottomBar(),
], ],
), ),