github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bump dartdoc to 0.32.3 and tighten doc quality checker (#63111)

Browse Source
This commit is contained in:
Michael Goderbauer 2020-08-07 20:41:04 -07:00 committed by GitHub
parent b7a1a397b2
commit e49a57660d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev/bots/docs.sh
View File

@ -37,7 +37,7 @@ function script_location() {
function generate_docs() { function generate_docs() {
# Install and activate dartdoc. # Install and activate dartdoc.
"$PUB" global activate dartdoc 0.32.1 "$PUB" global activate dartdoc 0.32.3
# This script generates a unified doc set, and creates # This script generates a unified doc set, and creates
# a custom index.html, placing everything into dev/docs/doc. # a custom index.html, placing everything into dev/docs/doc.

7
dev/tools/dartdoc_checker.dart
View File

@ -85,14 +85,9 @@ void checkForUnresolvedDirectives(String htmlOutputPath) {
int _scanFile(File file) { int _scanFile(File file) {
assert(path.extension(file.path) == 'html'); assert(path.extension(file.path) == 'html');
Iterable<String> matches = _pattern.allMatches(file.readAsStringSync()) final Iterable<String> matches = _pattern.allMatches(file.readAsStringSync())
.map((RegExpMatch m ) => m.group(0)); .map((RegExpMatch m ) => m.group(0));
// TODO(goderbauer): Remove this exception when https://github.com/dart-lang/dartdoc/issues/1945 is fixed.
matches = matches
.where((String m) => m != '{@inject-html}')
.where((String m) => m != '{@end-inject-html}');
if (matches.isNotEmpty) { if (matches.isNotEmpty) {
stderr.writeln('Found unresolved dartdoc directives in ${file.path}:'); stderr.writeln('Found unresolved dartdoc directives in ${file.path}:');
for (final String match in matches) { for (final String match in matches) {