github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove the rest of the uses of Number.tryParse() (#16568)

Browse Source
This commit is contained in:
Hans Muller 2018-04-13 09:39:01 -07:00 committed by GitHub
parent 1c3f6a851f
commit e7154bee1a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dev/bots/analyze-sample-code.dart
View File

@ -238,11 +238,13 @@ dependencies:
throw 'failed to parse error message: $error'; throw 'failed to parse error message: $error';
} }
final String column = error.substring(colon2 + kColon.length, bullet2); final String column = error.substring(colon2 + kColon.length, bullet2);
final int lineNumber = int.tryParse(line, radix: 10); // ignore: deprecated_member_use
final int lineNumber = int.parse(line, radix: 10, onError: (String source) => throw 'failed to parse error message: $error');
// ignore: deprecated_member_use
final int columnNumber = int.parse(column, radix: 10, onError: (String source) => throw 'failed to parse error message: $error');
if (lineNumber == null) { if (lineNumber == null) {
throw 'failed to parse error message: $error'; throw 'failed to parse error message: $error';
} }
final int columnNumber = int.tryParse(column, radix: 10);
if (columnNumber == null) { if (columnNumber == null) {
throw 'failed to parse error message: $error'; throw 'failed to parse error message: $error';
} }

3
packages/flutter_tools/lib/src/commands/fuchsia_reload.dart
View File

@ -384,7 +384,8 @@ class FuchsiaReloadCommand extends FlutterCommand {
final int lastSpace = trimmed.lastIndexOf(' '); final int lastSpace = trimmed.lastIndexOf(' ');
final String lastWord = trimmed.substring(lastSpace + 1); final String lastWord = trimmed.substring(lastSpace + 1);
if ((lastWord != '.') && (lastWord != '..')) { if ((lastWord != '.') && (lastWord != '..')) {
final int value = int.tryParse(lastWord); // ignore: deprecated_member_use
final int value = int.parse(lastWord, onError: (_) => null);
if (value != null) if (value != null)
ports.add(value); ports.add(value);
} }

3
packages/fuchsia_remote_debug_protocol/lib/src/fuchsia_remote_connection.dart
View File

@ -197,7 +197,8 @@ class FuchsiaRemoteConnection {
final int lastSpace = trimmed.lastIndexOf(' '); final int lastSpace = trimmed.lastIndexOf(' ');
final String lastWord = trimmed.substring(lastSpace + 1); final String lastWord = trimmed.substring(lastSpace + 1);
if ((lastWord != '.') && (lastWord != '..')) { if ((lastWord != '.') && (lastWord != '..')) {
final int value = int.tryParse(lastWord); // ignore: deprecated_member_use
final int value = int.parse(lastWord, onError: (_) => null);
if (value != null) { if (value != null) {
ports.add(value); ports.add(value);
} }