From e8dcf1909e8fad46b546bbff3e6712d5ce609bbb Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Fri, 16 Feb 2024 15:46:01 -0800 Subject: [PATCH] Implement `lineTerminator` in `MemoryStdout` Fake (#143608) https://dart-review.googlesource.com/c/sdk/+/326761/24/sdk/lib/io/stdio.dart#380 added a `lineTerminator` field to `Stdout`. Add that field to the fake in packages/test. Fixes https://github.com/flutter/flutter/issues/143614 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --- packages/flutter_tools/test/src/fakes.dart | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/packages/flutter_tools/test/src/fakes.dart b/packages/flutter_tools/test/src/fakes.dart index 33dfdb554ab..e7f38c93d98 100644 --- a/packages/flutter_tools/test/src/fakes.dart +++ b/packages/flutter_tools/test/src/fakes.dart @@ -193,6 +193,13 @@ class MemoryStdout extends MemoryIOSink implements io.Stdout { } bool _hasTerminal = true; + @override + // ignore: override_on_non_overriding_member + String get lineTerminator => '\n'; + set lineTerminator(String value) { + throw UnimplementedError('Setting the line terminator is not supported'); + } + @override io.IOSink get nonBlocking => this;