mirror of
https://github.com/flutter/flutter.git
synced 2025-06-03 00:51:18 +00:00
[gen_l10n] isCustomDateFormat
accepts an actual boolean (#153439)
Fixes #153420 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This commit is contained in:
parent
5d70d1914f
commit
ea477d5981
@ -283,6 +283,9 @@ class Placeholder {
|
||||
if (value == null) {
|
||||
return null;
|
||||
}
|
||||
if (value is bool) {
|
||||
return value;
|
||||
}
|
||||
if (value != 'true' && value != 'false') {
|
||||
throw L10nException(
|
||||
'The "$attributeName" value of the "$name" placeholder in message $resourceId '
|
||||
|
@ -1658,6 +1658,28 @@ import 'output-localization-file_en.dart' deferred as output-localization-file_e
|
||||
expect(content, contains(r"DateFormat('asdf o\'clock', localeName)"));
|
||||
});
|
||||
|
||||
testWithoutContext('handle arbitrary formatted date with actual boolean', () {
|
||||
setupLocalizations(<String, String>{
|
||||
'en': '''
|
||||
{
|
||||
"@@locale": "en",
|
||||
"springBegins": "Spring begins on {springStartDate}",
|
||||
"@springBegins": {
|
||||
"description": "The first day of spring",
|
||||
"placeholders": {
|
||||
"springStartDate": {
|
||||
"type": "DateTime",
|
||||
"format": "asdf o'clock",
|
||||
"isCustomDateFormat": true
|
||||
}
|
||||
}
|
||||
}
|
||||
}'''
|
||||
});
|
||||
final String content = getGeneratedFileContent(locale: 'en');
|
||||
expect(content, contains(r"DateFormat('asdf o\'clock', localeName)"));
|
||||
});
|
||||
|
||||
testWithoutContext('throws an exception when no format attribute is passed in', () {
|
||||
expect(
|
||||
() {
|
||||
|
Loading…
Reference in New Issue
Block a user