github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix analysis shard of dev/bots/test.dart so it works on Windows. (#21203)

Browse Source 
Normalize file path to non-Windows so string path comparison works.
This commit is contained in:
Alexander Aprelev 2018-08-30 14:47:04 -07:00 committed by GitHub
parent 6d7ecab25c
commit eab5cd9853
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dev/bots/analyze.dart
View File

@ -249,7 +249,8 @@ Future<Null> _verifyNoTestPackageImports(String workingDirectory) async {
})
.map<String>((FileSystemEntity entity) {
final File file = entity;
final String name = path.relative(file.path, from: workingDirectory);
final String name = Uri.file(path.relative(file.path,
from: workingDirectory)).toFilePath(windows: false);
if (name.startsWith('bin/cache') ||
name == 'dev/bots/test.dart' ||
name.startsWith('.pub-cache'))
@ -266,7 +267,7 @@ Future<Null> _verifyNoTestPackageImports(String workingDirectory) async {
return ' $name: Shim seems to be missing the expected import/export lines.';
}
final int count = 'package:test'.allMatches(data).length;
if (file.path.contains('/test_driver/') ||
if (path.split(file.path).contains('test_driver') ||
name.startsWith('dev/missing_dependency_tests/') ||
name.startsWith('dev/automated_tests/') ||
name.startsWith('packages/flutter/test/engine/') ||