github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable more web tests; use blacklist to filter them out (#41922)

Browse Source 
Add more web tests;use blacklist instead of whitelist
This commit is contained in:
Yegor 2019-10-07 15:05:24 -07:00 committed by GitHub
parent cf0d4979c7
commit ebfe6020b8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 27 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
dev/bots/test.dart
View File

@ -435,18 +435,28 @@ Future<void> _runTests() async {
}
Future<void> _runWebTests() async {
await _runFlutterWebTest(path.join(flutterRoot, 'packages', 'flutter'), tests: <String>[
'test/foundation/',
'test/physics/',
'test/services/',
// TODO(yjbanov): re-enable when flakiness is resolved
// 'test/rendering/',
// 'test/painting/',
// 'test/scheduler/',
// 'test/semantics/',
// 'test/widgets/',
// 'test/material/',
]);
final Directory flutterPackageDir = Directory(path.join(flutterRoot, 'packages', 'flutter'));
final Directory testDir = Directory(path.join(flutterPackageDir.path, 'test'));
// TODO(yjbanov): we're getting rid of this blacklist as part of https://github.com/flutter/flutter/projects/60
const List<String> kBlacklist = <String>[
'test/cupertino',
'test/examples',
'test/material',
'test/painting',
'test/rendering',
'test/semantics',
'test/widgets',
];
final List<String> directories = testDir
.listSync()
.whereType<Directory>()
.map<String>((Directory dir) => path.relative(dir.path, from: flutterPackageDir.path))
.where((String relativePath) => !kBlacklist.contains(relativePath))
.toList();
await _runFlutterWebTest(flutterPackageDir.path, tests: directories);
await _runFlutterWebTest(path.join(flutterRoot, 'packages', 'flutter_web_plugins'), tests: <String>['test']);
}

4
packages/flutter/test/gestures/transformed_monodrag_test.dart
View File

@ -334,7 +334,7 @@ void main() {
expect(startDetails, hasLength(1));
expect(updateDetails.single.globalPosition, within(distance: 0.0001, from: const Offset(400 + kTouchSlop + 3, 300 + kTouchSlop + 4)));
expect(updateDetails.single.delta, within(distance: 0.1, from: const Offset(5, 0.0))); // sqrt(3^2 + 4^2)
expect(updateDetails.single.primaryDelta, within(distance: 0.1, from: 5.0)); // sqrt(3^2 + 4^2)
expect(updateDetails.single.primaryDelta, within<double>(distance: 0.1, from: 5.0)); // sqrt(3^2 + 4^2)
});
});
@ -662,7 +662,7 @@ void main() {
expect(startDetails, hasLength(1));
expect(updateDetails.single.globalPosition, within(distance: 0.0001, from: const Offset(400 + kTouchSlop - 4, 300 + kTouchSlop + 3)));
expect(updateDetails.single.delta, within(distance: 0.1, from: const Offset(0.0, 5.0))); // sqrt(3^2 + 4^2)
expect(updateDetails.single.primaryDelta, within(distance: 0.1, from: 5.0)); // sqrt(3^2 + 4^2)
expect(updateDetails.single.primaryDelta, within<double>(distance: 0.1, from: 5.0)); // sqrt(3^2 + 4^2)
});
});
}

6
packages/flutter_test/lib/src/matchers.dart
View File

@ -1026,8 +1026,8 @@ double _sizeDistance(Size a, Size b) {
/// The distance is computed by a [DistanceFunction].
///
/// If `distanceFunction` is null, a standard distance function is used for the
/// `runtimeType` of the `from` argument. Standard functions are defined for
/// the following types:
/// `T` generic argument. Standard functions are defined for the following
/// types:
///
/// * [Color], whose distance is the maximum component-wise delta.
/// * [Offset], whose distance is the Euclidean distance computed using the
@ -1050,7 +1050,7 @@ Matcher within<T>({
@required T from,
DistanceFunction<T> distanceFunction,
}) {
distanceFunction ??= _kStandardDistanceFunctions[from.runtimeType];
distanceFunction ??= _kStandardDistanceFunctions[T];
if (distanceFunction == null) {
throw ArgumentError(

4
packages/flutter_tools/lib/src/web/chrome.dart
View File

@ -154,10 +154,6 @@ class ChromeLauncher {
return chrome;
}
/// Connects to an instance of Chrome with an open debug port.
static Future<Chrome> fromExisting(int port) async =>
_connect(Chrome._(port, ChromeConnection('localhost', port)), false);
static Future<Chrome> get connectedInstance => _currentCompleter.future;
/// Returns the full URL of the Chrome remote debugger for the main page.