github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable jank metrics for web (#109356)

Browse Source
This commit is contained in:
Jesús S Guerrero 2022-08-11 12:58:06 -07:00 committed by GitHub
parent 1dfa847785
commit edd466811d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_tools/lib/src/base/command_help.dart
View File

@ -120,7 +120,7 @@ class CommandHelp {
late final CommandHelpOption j = _makeOption( late final CommandHelpOption j = _makeOption(
'j', 'j',
'Dump frame raster stats for the current frame.', 'Dump frame raster stats for the current frame. (Unsupported for web)',
); );
late final CommandHelpOption k = _makeOption( late final CommandHelpOption k = _makeOption(

4
packages/flutter_tools/lib/src/resident_runner.dart
View File

@ -701,6 +701,10 @@ abstract class ResidentHandlers {
return false; return false;
} }
for (final FlutterDevice? device in flutterDevices) { for (final FlutterDevice? device in flutterDevices) {
if (device?.targetPlatform == TargetPlatform.web_javascript) {
logger!.printWarning('Unable to get jank metrics for web');
continue;
}
final List<FlutterView> views = await device!.vmService!.getFlutterViews(); final List<FlutterView> views = await device!.vmService!.getFlutterViews();
for (final FlutterView view in views) { for (final FlutterView view in views) {
final Map<String, Object>? rasterData = final Map<String, Object>? rasterData =

6
packages/flutter_tools/test/general.shard/terminal_handler_test.dart
View File

@ -177,6 +177,12 @@ void main() {
await terminalHandler.processTerminalInput('a'); await terminalHandler.processTerminalInput('a');
}); });
testWithoutContext('j unsupported jank metrics for web', () async {
final TerminalHandler terminalHandler = setUpTerminalHandler(<FakeVmServiceRequest>[], web: true);
await terminalHandler.processTerminalInput('j');
expect(terminalHandler.logger.warningText.contains('Unable to get jank metrics for web'), true);
});
testWithoutContext('a - debugToggleProfileWidgetBuilds without service protocol is skipped', () async { testWithoutContext('a - debugToggleProfileWidgetBuilds without service protocol is skipped', () async {
final TerminalHandler terminalHandler = setUpTerminalHandler(<FakeVmServiceRequest>[], supportsServiceProtocol: false); final TerminalHandler terminalHandler = setUpTerminalHandler(<FakeVmServiceRequest>[], supportsServiceProtocol: false);

2
packages/flutter_tools/test/integration.shard/overall_experience_test.dart
View File

@ -612,7 +612,7 @@ void main() {
'a Toggle timeline events for all widget build methods. (debugProfileWidgetBuilds)', 'a Toggle timeline events for all widget build methods. (debugProfileWidgetBuilds)',
'M Write SkSL shaders to a unique file in the project directory.', 'M Write SkSL shaders to a unique file in the project directory.',
'g Run source code generators.', 'g Run source code generators.',
'j Dump frame raster stats for the current frame.', 'j Dump frame raster stats for the current frame. (Unsupported for web)',
'h Repeat this help message.', 'h Repeat this help message.',
'd Detach (terminate "flutter run" but leave application running).', 'd Detach (terminate "flutter run" but leave application running).',
'c Clear the screen', 'c Clear the screen',