github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Set the ScrollConfiguration for dropdown menus (#5255)

Browse Source
This commit is contained in:
Hans Muller 2016-08-05 12:57:29 -07:00 committed by GitHub
parent 47139f1da9
commit eebe09d402
3 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
examples/flutter_gallery/flutter.yaml
View File

@ -25,7 +25,6 @@ assets:
- packages/flutter_gallery_assets/pesto/image9.jpg - packages/flutter_gallery_assets/pesto/image9.jpg
- packages/flutter_gallery_assets/pesto/logo_small.png - packages/flutter_gallery_assets/pesto/logo_small.png
- packages/flutter_gallery_assets/pesto/logo_medium.png - packages/flutter_gallery_assets/pesto/logo_medium.png
- packages/flutter_gallery_assets/pesto/logo_big.png
- packages/flutter_gallery_assets/pesto/fish.png - packages/flutter_gallery_assets/pesto/fish.png
- packages/flutter_gallery_assets/pesto/healthy.png - packages/flutter_gallery_assets/pesto/healthy.png
- packages/flutter_gallery_assets/pesto/main.png - packages/flutter_gallery_assets/pesto/main.png

3
examples/flutter_gallery/lib/demo/pesto_demo.dart
View File

@ -12,8 +12,7 @@ const String _kUserImage = 'packages/flutter_gallery_assets/pesto/avatar.jpg';
// Map of logo images keyed by the minimum height their container needs to be. // Map of logo images keyed by the minimum height their container needs to be.
final Map<double, String> _kLogoImages = <double, String>{ final Map<double, String> _kLogoImages = <double, String>{
0.0: 'packages/flutter_gallery_assets/pesto/logo_small.png', 0.0: 'packages/flutter_gallery_assets/pesto/logo_small.png',
70.0: 'packages/flutter_gallery_assets/pesto/logo_medium.png', 70.0: 'packages/flutter_gallery_assets/pesto/logo_medium.png'
170.0: 'packages/flutter_gallery_assets/pesto/logo_big.png',
}; };
final ThemeData _kTheme = new ThemeData( final ThemeData _kTheme = new ThemeData(

13
packages/flutter/lib/src/material/drop_down.dart
View File

@ -75,6 +75,16 @@ class _DropDownMenuPainter extends CustomPainter {
} }
} }
// Do not use the platform-specific default scroll configuration.
// Dropdown menus should never overscroll or display an overscroll indicator.
class _DropDownScrollConfigurationDelegate extends ScrollConfigurationDelegate {
const _DropDownScrollConfigurationDelegate();
@override
Widget wrapScrollWidget(Widget scrollWidget) => new ClampOverscrolls(value: true, child: scrollWidget);
}
final ScrollConfigurationDelegate _dropDownScroll = const _DropDownScrollConfigurationDelegate();
class _DropDownMenu<T> extends StatefulWidget { class _DropDownMenu<T> extends StatefulWidget {
_DropDownMenu({ _DropDownMenu({
Key key, Key key,
@ -159,6 +169,8 @@ class _DropDownMenuState<T> extends State<_DropDownMenu<T>> {
child: new Material( child: new Material(
type: MaterialType.transparency, type: MaterialType.transparency,
textStyle: route.style, textStyle: route.style,
child: new ScrollConfiguration(
delegate: _dropDownScroll,
child: new Scrollbar( child: new Scrollbar(
child: new ScrollableList( child: new ScrollableList(
scrollableKey: config.route.scrollableKey, scrollableKey: config.route.scrollableKey,
@ -169,6 +181,7 @@ class _DropDownMenuState<T> extends State<_DropDownMenu<T>> {
) )
) )
) )
)
); );
} }
} }