From fb8179bfedf309f57d37f78eff84f851a6c053b4 Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Mon, 9 Jan 2017 16:52:00 -0800 Subject: [PATCH] Remove a misfiring assert in the test framework plugin (#7397) Fixes https://github.com/flutter/flutter/issues/7351 When a test runs to completion, the test harness closes the stream side of the StreamChannel, causing the sink side to be closed as well. So by the time we receive a test result of completed/harnessBailed, the controller sink has been closed. --- packages/flutter_tools/lib/src/test/flutter_platform.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/flutter_tools/lib/src/test/flutter_platform.dart b/packages/flutter_tools/lib/src/test/flutter_platform.dart index 207f79930b3..93af3f414ad 100644 --- a/packages/flutter_tools/lib/src/test/flutter_platform.dart +++ b/packages/flutter_tools/lib/src/test/flutter_platform.dart @@ -164,7 +164,6 @@ class FlutterPlatform extends PlatformPlugin { harnessToTest.cancel(); testToHarness.cancel(); - assert(!controllerSinkClosed); switch (testResult) { case _TestResult.crashed: int exitCode = await process.exitCode;