Victoria Ashworth
fa01649a59
Update device selection to wait for wireless devices to load ( #122932 )
...
Update device selection to wait for wireless devices to load
2023-03-29 17:58:07 +00:00
Greg Spencer
c2f5bf99f1
Add macos project auto migration code for FlutterApplication ( #122336 )
...
Add macos project auto migration code for FlutterApplication
2023-03-16 01:01:03 +00:00
Victoria Ashworth
27248d4b64
Separate attached and wireless devices ( #122615 )
...
Separate attached and wireless devices
2023-03-15 16:35:05 +00:00
Victoria Ashworth
cc26a1aa0c
Update device filtering and introduce isConnected and connectionInterface ( #121359 )
...
Update device filtering and introduce isConnected and connectionInterface
2023-03-03 18:06:16 +00:00
Todd Volkert
c4ef072369
Cocoapods ffi error can be in stdout or stderr ( #121470 )
...
Cocoapods ffi error can be in stdout or stderr
2023-02-28 00:11:29 +00:00
Ian Hickson
6205c110d6
Remove "note that" in our documentation (as per style guide) ( #120842 )
...
* lerp documentation
* Remove Note, Note That from repo
* Improve BorderSide documentation.
* apply review comments
2023-02-17 22:27:33 +00:00
Chris Bracken
d272a3ab80
Reland: [macos] add flavor options to tool commands ( #119564 )
...
* Reland: [macos] add flavor options to tool commands
Adds --flavor option to flutter run and flutter build. Running against
preexisting devicelab flavor tests for feature parity between macOS,
iOS, and Android.
This relands #118421 by alex-wallen which was reverted in #118858 due to
the following test failures:
The bail-out with "Host and target are the same. Nothing to install."
added in `packages/flutter_tools/lib/src/commands/install.dart`
triggered failures in the following tests, which unconditionally attempt
to install the built app, which is unsupported on desktop since the
host and target are the same:
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791495589540422465/+/u/run_flutter_view_macos__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218824259121/+/u/run_complex_layout_win_desktop__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218165602641/+/u/run_flutter_gallery_win_desktop__start_up/test_stdout
Fixes #64088
* Partial revert: eliminate install check on desktop
The original flavour support patch included a check that triggered a
failure when flutter install is run on desktop OSes. This was
intentional, since the host and target devices are the same and
installation is unnecessary to launch the app on currently-supported
desktop OSes.
Note that Windows UWP apps *do* require installation to run, and we used
to have an install command for those apps, though UWP is no longer
supported.
Since that part of the change was orthogonal to flavour support itself,
I'm reverting that component of the change and we can deal with it
separately if so desired.
2023-01-31 17:37:46 +00:00
Victoria Ashworth
a07e8a6ac4
[reland] Support wireless debugging ( #118895 )
...
* Reland "Support iOS wireless debugging (#118104 )"
This reverts commit cbf2e16892
2023-01-20 19:02:37 +00:00
Jenn Magder
030288d33b
Revert "[macos] add flavor options to commands in the flutter_tool ( #118421 )" ( #118858 )
...
This reverts commit 73096fd96e
2023-01-20 03:46:45 +00:00
Alex Wallen
73096fd96e
[macos] add flavor options to commands in the flutter_tool ( #118421 )
...
* Add new macos target configured for flavors
* Rename Free App copy-Info.plist to Free App Info.plist
* Remove bogus entitlements
* Remove Generated.xcconfig
* Audit project.pbxproj
* Remove unused configs
* share one info.plist
* Modify scheme so that paid app works
* Codesign automatic
* Pipe flavor as scheme into xcodebuild
* Ignore incoming flavor string
* pipe flavor for flutter run to work
* Add devicelab tests
* Error if host and target device are same for flutter install desktop
* Avoid bang (!) by promoting a local.
Co-authored-by: Jenn Magder <magder@google.com>
* Add supportsInstall property
* Override in test classes
* Add install test on macOS
* Refactor application_package and add tests for package directory
Co-authored-by: a-wallen <stephenwallen@google.com>
Co-authored-by: Jenn Magder <magder@google.com>
2023-01-19 23:52:16 +00:00
Jenn Magder
cbf2e16892
Revert "Support iOS wireless debugging ( #118104 )" ( #118826 )
...
This reverts commit 5cd2d4c61e
2023-01-19 12:31:53 -08:00
Victoria Ashworth
5cd2d4c61e
Support iOS wireless debugging ( #118104 )
...
* setup wireless debugging to use device IP
* fix tests
* fix unused var and missing annotation
* remove unneeded try catch
* remove commented out line, change null to package id
* better way to get package id
* update mDNS lookup to continously check for server, add messaging if takes too long to find observatory url, update flutter drive to enable publish-port if using network device
* Refactor mDNS Discovery to poll for observatories and better handle multiple instances of the same app. Update drive command to make publish-port more stable. Update attach for iOS to only use Protocol Discovery if applicable, run mDNS and Protocol Discovery simultaneously, handle --debug-port/--debug-url/--device-vmservice-port, continously poll for obseravtories with mDNS, include port in error message when mutliple available
* add and update comments, use logger spinner intead of timer in flutter attach, other small improvements
* add newline to message so next log won't be on same line
* fix install/waiting for permission status progress so it doens't double print the time it took.
* only print backtrace if observatory times out on a physical usb connected device
* fix test
* Update related references from Observatory to Dart VM Service
* fix test
2023-01-19 20:00:21 +00:00
hellohuanlin
0916375f44
[tools]Build IPA validation UI Polish ( #116744 )
...
* [tools]some ui polish for build ipa validation
* do not print out a few success validations
* rename installed type to success for more general usage
* forgot nit after reverting custom validation types and re-use doctor types
2022-12-15 14:43:32 -08:00
Jenn Magder
ada4460502
Audit covariant usage in tool ( #116930 )
2022-12-15 11:59:34 -08:00
Chris Bracken
3c9288c6d3
Increase minimum supported macOS version from 10.13 to 10.14 ( #114713 )
...
Increases the minimum macOS deployment target from macOS 10.13 (High Sierra) to 10.14 (Mojave) in the macOS app templates.
Includes:
* Update migration for macOS 10.11 apps to upgrade to 10.14
* Adds migration for macOS 10.13 apps to upgrade to 10.14
* Apply migration to all examples, and integration tests
This does not increase version in the plugin templates since those will need to wait until the 10.14 framework rolls to stable channel, so new plugins can build with apps created with `flutter create` on stable channel.
Issue: https://github.com/flutter/flutter/issues/114445
See RFC: http://flutter.dev/go/flutter-drop-macOS-10.13-2022-q4
See previous patch: https://github.com/flutter/flutter/pull/107689
2022-11-07 11:32:42 +01:00
Chris Bracken
5bc50c136b
Fix macOS migration nothing-to-upgrade test ( #114703 )
...
When testing whether a macOS deployment target version migration is
unnecessary due to already being at the target version, we were
previously checking the iOS deployment target version rather than the
macOS version. This updates it to test MACOSX_DEPLOYMENT_TARGET instead.
2022-11-05 17:02:46 -07:00
Jenn Magder
b82cf76ff6
Return void from project migrate() ( #112897 )
2022-10-05 20:22:56 +00:00
Zachary Anderson
c6ec84e978
[flutter_tools] Pull more arm64 artifacts on Apple Silicon ( #110291 )
2022-08-29 10:33:24 -07:00
Jenn Magder
7c7ae991e5
Use hasNoRemainingExpectations matcher for fake process manager in tool tests ( #108649 )
2022-07-30 02:02:05 +00:00
Jenn Magder
167655e8a7
Only show iOS simulators, reduce output spew in verbose ( #108345 )
2022-07-26 19:08:06 +00:00
Jenn Magder
c4975d9be0
Increase app minimum supported macOS version from 10.11 to 10.13 ( #107689 )
2022-07-15 11:12:43 -07:00
Jonah Williams
db829c1e20
[flutter_tools] migrate more unit tests to null safety ( #106153 )
2022-06-17 21:34:27 -07:00
Jenn Magder
aba0c4e6f6
Do not show diagnostic warning for disconnected iOS devices ( #105971 )
2022-06-18 01:52:07 +00:00
Jesús S Guerrero
32b22b85de
parse build version on xcodeproj ( #105908 )
2022-06-16 22:26:06 +00:00
Michael Goderbauer
3fa355c97d
Remove dead code in tools tests ( #104567 )
2022-05-25 12:48:17 -07:00
Jenn Magder
a56c5e51ae
Migrate some test files to null safety ( #104469 )
2022-05-24 16:53:08 -07:00
Jenn Magder
bf7a32628e
Up CocoaPods minumum to 1.10 ( #103655 )
2022-05-16 17:42:19 -07:00
Jenn Magder
2e1c146eec
Update ffi gem installation instructions ( #103008 )
2022-05-04 13:24:08 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals ( #102585 )
2022-04-27 09:15:35 +02:00
Jenn Magder
c9825d24dd
Handle CocoaPods ffi stderr ( #102327 )
2022-04-21 15:49:08 -07:00
Jenn Magder
fe11f57c61
Detect ARM ffi CocoaPods bus error ( #101796 )
2022-04-14 14:34:10 -07:00
Jenn Magder
8f360c977a
Update minimum required version to Xcode 13 ( #97746 )
2022-03-01 16:26:11 -08:00
Jenn Magder
320d2cff64
Increase recommended CocoaPods version to 1.11 ( #98621 )
2022-02-24 12:11:21 -08:00
Lau Ching Jun
7f0050f5b3
Add a new PrebuiltFlutterApplicationPackage interface. ( #95290 )
...
* Add a new PrebuiltFlutterApplicationPackage interface.
* Review feedback
* Rename bundleDir to uncompressedBundle
2022-01-05 07:54:57 -08:00
Jenn Magder
f7bd20fc09
Detect additional ARM ffi CocoaPods error ( #94385 )
2021-12-07 15:29:03 -08:00
Greg Spencer
52ae102f18
Adds tool warning log level and command line options to fail on warning/error output ( #92031 )
2021-11-10 16:13:04 -08:00
Jenn Magder
6cbed01db3
Migrate windows_device to null safety ( #92956 )
2021-11-07 01:27:34 -07:00
Jenn Magder
31933af486
Update minimum required version to Xcode 12.3 ( #93094 )
2021-11-05 16:08:04 -07:00
Jenn Magder
9e88fe328e
Remove globals_null_migrated.dart, move into globals.dart ( #92861 )
2021-11-01 17:18:03 -07:00
嘟囔
41167c957d
feat: migrate macos/macos_device.dart to null safety ( #92633 )
2021-10-29 16:14:35 -07:00
Jenn Magder
aff69e43ef
Add integration_test to flavor test project ( #92520 )
2021-10-27 12:53:05 -07:00
Jenn Magder
8474f41e90
Migrate xcdevice and ios devices to null safety ( #92056 )
2021-10-19 12:23:03 -07:00
Jenn Magder
a82c50f1f6
Revert "Migrate xcdevice and ios devices to null safety ( #91704 )" ( #91912 )
...
This reverts commit 0065873670
2021-10-15 09:48:08 -07:00
Jenn Magder
0065873670
Migrate xcdevice and ios devices to null safety ( #91704 )
2021-10-14 22:28:02 -07:00
Jenn Magder
8930e9b892
Catch FormatException parsing XCDevice._getAllDevices ( #90967 )
2021-10-08 13:08:04 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be24
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint ( #91409 )
2021-10-07 20:13:02 -07:00
Jenn Magder
c48c428e46
Xcode 13 as minimum recommended version ( #90906 )
2021-09-30 12:23:55 -07:00
Anis Alibegić
a753d09cc9
Fixed several typos ( #89485 )
2021-09-07 14:56:04 -07:00
Jenn Magder
d550d497f1
Migrate some flutter_tools tests to null safety ( #88850 )
2021-08-25 16:21:04 -07:00
Taha Tesser
42a6b7913c
[tools] Add Xcode version to non-verbose Flutter doctor ( #87022 )
2021-08-17 15:52:03 -07:00
Jenn Magder
325cfb0f4c
Make doctor Xcode version requirement clearer ( #88137 )
2021-08-13 17:07:03 -07:00
Zachary Anderson
f0e832cdea
[flutter_tool] Fix DesktopLogReader to capture all output ( #88116 )
2021-08-12 14:57:07 -07:00
Darren Austin
b08366ce7b
Updated skipped tests for flutter_tools. ( #87925 )
...
* Updated skipped tests for flutter_tools.
* Turned the flaky overall_experience test off as it was still failing on CI.
2021-08-10 22:22:08 -07:00
嘟囔
bffa11e2b6
fix: fix BuildableMacOSApp pass no projectBundleId to super error ( #87264 )
2021-08-06 14:30:07 -07:00
Jenn Magder
e028d0f046
Split project.dart into CMake and Xcode projects ( #85359 )
2021-06-28 11:31:04 -07:00
Jonah Williams
88e756d19e
[flutter_tools] well known device ids ( #85184 )
2021-06-24 18:46:04 -07:00
Balvinder Singh Gambhir
604c59e522
adds build number of ios device in flutter devices command ( #84512 )
2021-06-23 11:31:03 -07:00
Jenn Magder
e87a85c30e
Add Designed by iPad attach destination for ARM macOS ( #84411 )
2021-06-14 12:09:02 -07:00
Jenn Magder
4c6a9dcb40
Migrate a few tool libraries to null safety ( #83862 )
2021-06-04 10:49:04 -07:00
Hattomo (TomohiroHattori)
08a70e7ac8
Enable avoid_escaping_inner_quotes lint ( #81153 )
2021-05-19 09:54:02 -07:00
Jenn Magder
25c10d6a1c
Replace testUsingContext with testWithoutContext in a few places ( #82498 )
2021-05-13 23:09:03 -07:00
Jonah Williams
ce9aee6606
[flutter_tools] remove mocks from xcode test ( #81451 )
2021-04-30 09:44:01 -07:00
Jonah Williams
7c27db3dfe
[flutter_tools] remove mocks and globals from macOS tests ( #81401 )
2021-04-28 13:44:02 -07:00
Matej Knopp
f6726b425d
Add support for DarwinArchs when assembling macOS App.framework ( #81243 )
2021-04-28 11:33:36 -07:00
Jenn Magder
db3f49b1b4
Use cached Xcode build settings during iOS build ( #80904 )
2021-04-27 17:20:11 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations ( #80817 )
2021-04-21 13:49:03 -07:00
Jenn Magder
515003e4af
Migrate xcode.dart and xcode_validator.dart to null safety ( #80614 )
2021-04-18 14:39:03 -07:00
Jenn Magder
72976f552c
Migrate xcodeproj to null safety ( #80549 )
2021-04-16 17:22:46 -07:00
Jenn Magder
56c0002c47
Adopt FakeProcessManager.empty ( #80480 )
2021-04-15 14:19:02 -07:00
Jenn Magder
ddc1c296a1
Pull XCDevice out of xcode.dart ( #80324 )
2021-04-13 18:10:21 -07:00
Jenn Magder
d40cc5af8f
Migrate flutter_tool plugins.dart to null safety ( #80304 )
2021-04-13 13:52:58 -07:00
Jenn Magder
ba764ebc38
Update Podfile.lock modified timestamp when pod install is run ( #78823 )
2021-04-06 15:54:02 -07:00
Jonah Williams
0a59698ebe
[flutter_tools] migrate cache to null safety ( #79864 )
2021-04-06 14:44:02 -07:00
Jenn Magder
79f1689f6a
Migrate doctor_validator to null safety ( #79682 )
2021-04-05 11:54:54 -07:00
Jenn Magder
8ddc27e607
Split globals.dart into null sound and unsound libraries ( #79016 )
2021-03-31 16:55:20 -07:00
Jenn Magder
5a6d2a0a8e
Check for outdated Podfile before running pod install ( #79343 )
2021-03-30 12:42:39 -07:00
Jenn Magder
d165ea5c42
Migrate os to null safety ( #78901 )
2021-03-23 17:28:09 -07:00
Jenn Magder
0cf1007276
Remove mocks from cocoapods_test ( #78279 )
2021-03-16 13:53:04 -07:00
Jenn Magder
c3d0f60407
Remove mock from cocoapods_validator_test ( #77991 )
2021-03-12 19:14:05 -08:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint ( #77434 )
2021-03-05 18:38:15 -08:00
Michael Goderbauer
807bb29888
enable prefer_function_declarations_over_variables lint ( #77398 )
2021-03-05 18:29:04 -08:00
Jenn Magder
67b2ca893e
Update minimum required version to Xcode 12 ( #77025 )
2021-03-03 11:00:35 -08:00
Jonah Williams
2951363dc8
[flutter_tools] switch FakeCache to cache.test and NoopUsage to TestUsage ( #76802 )
2021-02-26 11:13:32 -08:00
Sam Rawlins
ba58ad0385
Remove "unnecessary" imports in test/general.shard ( #75954 )
2021-02-18 13:38:24 -08:00
Jonah Williams
04182572f7
[flutter_tools] allow bypassing context for FlutterProject creation, remove fromPath ( #76258 )
2021-02-18 12:36:04 -08:00
Jenn Magder
23e41734e5
Swap Mocks to Fakes in config_test ( #76274 )
2021-02-18 00:46:02 -08:00
Jenn Magder
ba5e237e24
Avoid duplicating Pods-Runner xcconfig #includes ( #75822 )
2021-02-11 14:11:15 -08:00
Jenn Magder
5a2c917dd8
Fix analyzer warning, remove import ( #75717 )
2021-02-09 10:50:05 -08:00
Jenn Magder
152d88a3df
Add exception to FakeCommand ( #75545 )
2021-02-09 10:07:46 -08:00
Jonah Williams
021311ed8a
Revert "[flutter_tools] move process manager into tool ( #75350 )" ( #75639 )
...
This reverts commit 8b6baae44c
2021-02-08 09:21:46 -08:00
Jonah Williams
8b6baae44c
[flutter_tools] move process manager into tool ( #75350 )
...
Our current top crasher is an unclear error when ProcessManager fails to resolve an executable path. To fix this, we'd like to being adjusting the process resolution logic and adding more instrumentation to track failures. In order to begin the process, the ProcessManager has been folded back into the flutter tool
2021-02-04 13:19:11 -08:00
Jenn Magder
dc30327a4d
Replace MockProcessManager with FakeProcessManager in cocoapods_test ( #74956 )
2021-01-29 14:32:33 -08:00
Jenn Magder
6ecb8cbcfa
Replace MockUsage with TestUsage ( #74946 )
2021-01-28 18:49:04 -08:00
Jonah Williams
b926c7b696
[flutter_tools] rewrite Usage.test to capture objects instead of print logs ( #74829 )
2021-01-28 12:41:14 -08:00
Jonah Williams
74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. ( #74832 )
...
* opt out the flutter tool
* oops EOF
* fix import
* Update tool_backend.dart
* Update daemon_client.dart
* fix more
2021-01-27 15:17:53 -08:00
Jenn Magder
675fd5540e
Replace MockXcode with Xcode.test in unit tests ( #74777 )
2021-01-27 11:04:03 -08:00
Jenn Magder
7c75c01fc3
Add recommended Xcode version to doctor ( #73808 )
2021-01-12 19:01:18 -08:00
Jenn Magder
bc7286f118
Use simctl exit code instead of stderr ( #73070 )
2021-01-07 13:13:56 -08:00
