Commit Graph

135 Commits

Author SHA1 Message Date
Danny Tuppeny
127d1f85dd
Improve error message in microbenchmarks when flutter run lives too long (#19200)
This should make it more obvious from the error what's gone wrong if we see a repeat of #19096 (previously the error was something like "Bad state: future already completed").
2018-07-10 17:09:39 +01:00
Danny Tuppeny
5413560415 Revert "Add temporary debug prints to identify devicelab failures (#19093)" (#19095)
This reverts commit edc16473bf.
2018-07-05 18:58:26 +02:00
Danny Tuppeny
edc16473bf
Add temporary debug prints to identify devicelab failures (#19093) 2018-07-05 14:16:44 +01:00
Danny Tuppeny
e1d396d5ca
Attempt to fix race in microbenchmark error handling code (#19092)
Await stream cancellations before trying to complete
2018-07-05 13:06:43 +01:00
Mikkel Nygaard Ravn
c34daae2d6
Avoid repeating microbenchmark (#19087) 2018-07-05 11:11:17 +02:00
liyuqian
8c1d8a6a6b
Add 90th and 99th percentiles to dashboard (#18930)
This fixes #18727
2018-06-28 16:19:23 -07:00
Ian Hickson
35ad2a786d
Remove race conditions involving finding available ports (#18698)
This is an attempt to reland #18488 with less breakage on macOS.
2018-06-27 16:44:28 -07:00
Jason Simmons
43e6372128
Update the ICU data file asset path in the devicelab tests (#18854) 2018-06-26 16:01:31 -07:00
Michael Goderbauer
f11b790b8c
Track size of App.framework and Flutter.framework for Hello World (#18701) 2018-06-22 09:27:31 -07:00
Greg Spencer
08d1ec36de Roll engine to 0c119932c0d6cb30dafd75ec717d1eda76fd7651 (#18575) 2018-06-19 09:58:20 +02:00
Michael Goderbauer
9a8c4dfef6
Report compressed/uncompressed size of icudtl, snapshots, and libflutter (#18583)
Reported for the hello_world compile benchmark in devicelab for now.
2018-06-18 17:12:14 -07:00
Michael Goderbauer
ebb174b0bf
Add size benchmark for hello_world (#18522) 2018-06-16 00:08:33 -07:00
Michael Goderbauer
2a19dae28b
Fix aot_snapshot_size_* benchmarks (#18520)
... and make sure they fail if they can't report the size.
2018-06-15 17:17:28 -07:00
Ian Hickson
0fa5ba43a1
Revert "Remove race conditions involving finding available ports (#18488)" (#18521)
This reverts commit 7750872251.
2018-06-15 15:37:20 -07:00
Ian Hickson
7750872251
Remove race conditions involving finding available ports (#18488) 2018-06-15 14:16:18 -07:00
Michael Goderbauer
409007827b
Keep TextFields visible when keyboard comes up (#18291)
Fixes #10826.

Also in this PR: If you focus a text field, scroll it out of view and then start typing it will scroll back into view.
2018-06-15 10:11:10 -07:00
Chris Bracken
2ae48845a8
Revert elimination of Dart 1 (#18460)
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
from source, flutter_platform.dart automatically runs a kernel compile when
operating in Dart 2 mode, but this assumes a functional Dart SDK is available
in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
directory with an empty temp dir.

Remaining work is:
1. Get the frontend server building as a dependency on Fuchsia.
2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.

This also reverts migration to Dart 2 typedef syntax.

This reverts commit 6c56bb2. (#18362)
This reverts commit 3daebd0. (#18316)
2018-06-13 12:46:39 -07:00
Greg Spencer
6c56bb2420
Update typedef syntax to use Function notation and turn on lint for old notation. (#18362)
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.

Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.

No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
2018-06-11 15:51:45 -07:00
Chris Bracken
3daebd059c
It's time to #deleteDart1 (again) (#18316)
* It's time to #deleteDart1 (#18293)

Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
benchmarks. All commands now run in Dart 1 mode only.

Eliminates --preview-dart-2 / --no-preview-dart-2 support.

* Fix indentation, remove no longer necessary .toList()

* Only push udpated kernel if >0 invalidated srcs
2018-06-08 15:49:24 -07:00
Chris Bracken
9495df4bc3
Revert "It's time to #deleteDart1 (#18293)" (#18313)
Several benchmarks started failing during kernel compile:
1. Timeouts:
   * commands_test
   * hot_mode_dev_cycle__benchmark
   * run_machine_concurrent_hot_reload
   * service_extensions_test

2. Kernel compiler crash:
   * hot_mode_dev_cycle_linux__benchmark
   * routing_test

3. Unexpected termination:
   * hot_mode_dev_cycle_win__benchmark

This reverts commit ed63e7082a.
2018-06-08 12:43:11 -07:00
Chris Bracken
ed63e7082a
It's time to #deleteDart1 (#18293)
Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
benchmarks. All commands now run in Dart 1 mode only.

Eliminates --preview-dart-2 / --no-preview-dart-2 support.
2018-06-08 11:04:57 -07:00
Alexandre Ardhuin
09276bea25
enable lint prefer_equal_for_default_values (#18156) 2018-06-05 08:50:40 +02:00
Greg Spencer
b921fdc58e
Revert "Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)" (#18041)
This reverts commit 3258602073.
2018-05-30 13:51:14 -07:00
Greg Spencer
3258602073
Update typedef syntax to use Function notation and turn on lint for old notation. (#18035)
Fixes #18028

Just changes typedef declarations, no logic changes.
2018-05-30 12:13:58 -07:00
Sarah Zakarias
a3e71bf11f
Add startup test for Platform View example (#17645) 2018-05-16 13:24:47 +02:00
Todd Volkert
d820e5f3b1
Use deprecated io constants (#17278)
The new values are not ready for use yet inside Google
2018-05-03 22:27:29 -07:00
Yegor
b2c98f9a4e
Roll engine to e976be13c51448f89107d082ec81e2b6731671fa (#17266)
* Roll engine to e976be13c51448f89107d082ec81e2b6731671fa

* move away from deprecated constants
2018-05-03 19:24:48 -07:00
Yegor
a90a850462
bump benchmark timeouts (#16817) 2018-04-20 13:57:06 -07:00
Chinmay Garde
9a0b562524
When parsing logs, filter away lines that are irrelevant to the microbenchmark. (#16678) 2018-04-17 16:57:47 -07:00
Todd Volkert
ec26a7baca
Fail with better error message in microbenchmarks (#16676) 2018-04-17 14:34:09 -07:00
Alexander Aprelev
254c45e471
Add hotReloadMillisecondsToFrameAfterChange benchmark. (#16406)
This fixes https://github.com/dart-lang/sdk/issues/32598.
2018-04-10 07:25:22 -07:00
Mikkel Nygaard Ravn
77403ba6ec
Experiment to understand test flakiness (#15872) 2018-03-29 00:24:05 +02:00
Mikkel Nygaard Ravn
ce28378178
Change to absolute path (#15827) 2018-03-23 11:37:56 +01:00
Mikkel Nygaard Ravn
f90c54c6ed
Fix path to .bat file (#15824) 2018-03-22 13:22:44 +01:00
Mikkel Nygaard Ravn
145abb6dbf
Stop Gradle daemon before attempting to delete Flutter project (#15819) 2018-03-22 12:33:29 +01:00
Alexander Aprelev
ffc7fac288
Pass --no-preview-dart-2 for dart1 tests. (#15800) 2018-03-21 13:40:17 -07:00
Alexander Aprelev
21ad09fe57
With dart2 being default, move preview_dart_2 tests to dart1. (#15667)
* With dart being default, move preview_dart_2 tests to dart1.

* Swap out defaults for preview-dart-2 option in tests. Make dart1 explicit

* Move suffix around

* Rename files
2018-03-19 12:11:18 -07:00
Alexander Aprelev
2f8474f9aa
Roll engine to b6df7a637498ca9beda1fa9cd7210e3202ea599f. (#15444)
* Roll engine to b6df7a637498ca9beda1fa9cd7210e3202ea599f.

Changes since last roll:
```
b6df7a637 Roll dart to 290c576264faa096a0b3206c71b2435309d9f904. (#4771)
a6764dbd5 Add sources for Fuchsia target. (#4763)
2d5900615 [fuchsia] Remove unused header file. (#4769)
9717063b7 Revert "Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767)" (#4768)
9a9814312 Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767)
e74e8b35c [async] Update includes of async headers to new path (#4760)
e2c4b2760 Use Dart 2 camel case constants in the engine Dart libraries (#4766)
9c1e48434 Updates for Fuchsia roll. (#4765)
14c940e27 Switch from fxl::Mutex to std::mutex (#4764)
debf82c0b Roll Garnet (#4759)
5bffdefbb Use weak pointers to the accesibility bridge from objects vended to the UIKit accessibility framework. (#4761)
```
2018-03-12 15:44:25 -07:00
Mikkel Nygaard Ravn
658f9e6c83
Make plugins work in Swift projects (#15437) 2018-03-12 17:33:10 +01:00
Alexander Aprelev
758b302c8d
Add --preview-dart-2 relaunch test. (#15117)
* Add a test that measures/verifies start from warm state(app was previously compiled).

* Remove json file from the first run.
2018-03-06 14:33:26 -08:00
Mikkel Nygaard Ravn
2000435728
Move plugin injection to just after pub get (#14743) 2018-02-16 10:17:28 +01:00
Mikkel Nygaard Ravn
c2e1bc0322
Revert "Move plugin injection to just after pub get (#14560)" (#14734)
This reverts commit b3e4976ca2.
2018-02-15 22:55:36 +01:00
Mikkel Nygaard Ravn
b3e4976ca2
Move plugin injection to just after pub get (#14560) 2018-02-15 22:17:12 +01:00
Alexandre Ardhuin
c02b6a8bcf
some whitespace cleanup (#14443) 2018-02-02 23:27:29 +01:00
xster
82ddabd32a
Fastlane instructives for tool publishing the Gallery (#14347)
* first round fastlane working on Android

* clean up and start ios

* Partial iOS

* Got a fastfile that works on iOS

* Finalize Android push instructions

* Finalize instructions for iOS

* Extra cleanup and optipng

* Disable readme autogen and add a default readme
2018-01-31 11:21:37 -08:00
Alexander Aprelev
5b02a5ec58
Fix iOS automatic signing on buildbots. (#14024) 2018-01-10 14:01:20 -08:00
Leaf Petersen
b3cfa785c4
Uncontroversial and backwards compatible 2.0 SDK fixes (#13723)
Small code changes as part of moving the framework SDK forward to a 2.0 dev version.
2017-12-21 13:39:03 -08:00
Yegor
1c6decaa5e
update APK path in devicelab tests (#13540)
* update APK path in devicelab tests

* add missing transitive dependency on archive

* use path used by flutter tools
2017-12-13 13:12:10 -08:00
Vyacheslav Egorov
41a5e5d8f6 Change few devicelab tests to support testing against local engine (#13268)
* Change some of the dev/devicelab tests to support testing against local engine.

We can already configure flutter tools to use local engine by setting
FLUTTER_ENGINE environment variable. However when this variable is set
this also requires setting --local-engine to specify which flavor of
engine to use.

This change changes tests in dev/devicelab to pass a sensible default for
--local-engine, e.g. when testing hot reload on Android we pass android_debug
and when testing release AOT build for IOS we pass ios_release.

* Fix analysis issues

* Update utils.dart
2017-11-30 12:15:27 -08:00
Ian Hickson
1bef312fb1
Actually run "flutter create" before compiling the default app... (#13246) 2017-11-29 15:49:50 -08:00