62 Commits

Author	SHA1	Message	Date
Michael Goderbauer	5491c8c146	Auto-format Framework (#160545) ... This auto-formats all *.dart files in the repository outside of the `engine` subdirectory and enforces that these files stay formatted with a presubmit check. **Reviewers:** Please carefully review all the commits except for the one titled "formatted". The "formatted" commit was auto-generated by running `dev/tools/format.sh -a -f`. The other commits were hand-crafted to prepare the repo for the formatting change. I recommend reviewing the commits one-by-one via the "Commits" tab and avoiding Github's "Files changed" tab as it will likely slow down your browser because of the size of this PR. --------- Co-authored-by: Kate Lovett <katelovett@google.com> Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>	2024-12-19 20:06:21 +00:00
Danny Tuppeny	9fcbcd4357	Fix some broken links in DAP readme (#155600) ... The location of the DAP readme in the Dart SDK repo moved. Some of the links here got updated, but apparently not all.	2024-09-24 14:47:24 +00:00
Danny Tuppeny	3f038aea0b	[flutter_tools] Fix encoded stderr in "dart.log" from debug adapter to client (#155249) ... To aid debugging, debug adapter (DAP) clients can ask the debug adapters to send verbose logs back to the client (so they can capture them in a client-side log along with other things happening on the client). Included in this log is the `stderr` output of the `flutter run` process spawned by the debug adapter. This output was not decoded correctly for these logs, so showed up like: ``` [Flutter] [stderr] [91, 32, 32, 43, 49, 52, 32, 109, 115, 93, 32, 67, 111, 117, 108, 100, 32, 110, 111, 116, 32, 102, 105, 110, 100, 32, 97, 110, 32, 111, 112, 116, 105, 111, 110, 32, 110, 97, 109, 101, 100, 32, 34, 105, 110, 118, 97, 108, 105, 100, 34, 46, 10, 10, 91, 32, 32, 32, 32, 32, 32, 32, 32, 93, 32, 82, 117, 110, 32, 39, 102, 108, 117, 116, 116, 101, 114, 32, 45, 104, 39, 32, 40, 111, 114, 32, 39, 102, 108, 117, 116, 116, 101, 114, 32, 60, 99, 111, 109, 109, 97, 110, 100, 62, 32, 45, 104, 39, 41, 32, 102, 111, 114, 32, 97, 118, 97, 105, 108, 97, 98, 108, 101, 32, 102, 108, 117, 116, 116, 101, 114, 32, 99, 111, 109, 109, 97, 110, 100, 115, 32, 97, 110, 100, 32, 111, 112, 116, 105, 111, 110, 115, 46, 10] ``` This change decodes the output before processing. Fixes https://github.com/Dart-Code/Dart-Code/issues/5268 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md	2024-09-24 12:30:06 +01:00
Andrew Kolos	91813060c0	[tool] Guard more write/writeln calls on Process.stdin (#151146) ... Contributes to fixing https://github.com/flutter/flutter/issues/137184. This PR guards write calls in non-test files. This PR excludes * packages/flutter_tools/lib/src/dart/analysis.dart due to a test timeout I would like to figure out in a separate PR and * packages/flutter_tools/lib/src/compile.dart due to https://github.com/flutter/flutter/issues/151255	2024-07-23 19:27:52 +00:00
Snoppy	65cd7cf7b2	chore: fix typos and link broken (#150402) ... **fix some typos and link broken**	2024-07-03 17:10:19 +00:00
Danny Tuppeny	ce0e5c4330	[flutter_tools] Update the mapping for the Dart SDK internal URI (#151170) ... This changes the mapping for the Dart SDK inside Flutter from `org-dartlang-sdk:///third_party/dart/sdk` to org-dartlang-sdk:///flutter/third_party/dart/sdk`. This URI changed in https://github.com/flutter/engine/pull/51917 but was not caught by tests because they only tested a specific set of mappings and there were no integration tests checking what URIs were actually produced by a running app. So, this change also adds an integration tests that ensures that a real running app produces URIs that are then correctly mapped. Fixes https://github.com/Dart-Code/Dart-Code/issues/5164.	2024-07-02 22:56:17 +00:00
Danny Tuppeny	eb58fe16b6	[flutter_tools] Include more details in structured errors sent to a DAP client (#150698) ... The debug adapter converts Flutter's structured errors into a text format to be sent to the debug client and shown in the console. When an error is not the first error since the last reload, it is shown as just a summary (since it may be caused by a prior error). In this mode, the filter was causing some important information (the erroring widget) to be omitted. This tweaks the logic to include child nodes of a `DiagnosticBlock` in this mode. Fixes https://github.com/Dart-Code/Dart-Code/issues/4743 ## Before:  ## After: 	2024-06-28 06:36:03 +00:00
Danny Tuppeny	e250c655d1	[flutter_tools/dap] Handle app.stop errors when launching/attaching (#149734) ... Two issues I noticed when I hit the issue at https://github.com/flutter/flutter/issues/149258 1. When the an app.stop event arrives from Flutter with an error, DAP does not pass that error back to the client so there's no visibility of the error. 2. If app.stop occurs but no app.start ever did, we leave the progress notification hanging around This fixes both by handling app.stop and closing any open launch progress as well as passing any error to the client. Fixes https://github.com/Dart-Code/Dart-Code/issues/5124	2024-06-25 10:56:29 +00:00
Danny Tuppeny	cea1d6f055	Unpin DDS and roll pub packages (#147925) ... DDS was temporarily pinned to 4.1.0 because 4.2.0 triggered some test failures (see https://github.com/flutter/flutter/pull/147250). Those failures should be fixed by vm_service 14.2.2, so this unpins DDS and rolls both of these packages (along with devtools_shared, which is a DDS dependency). (If the bot updates vm_service before this is done, I can rebase over that will reduce the size of this PR to just a few files)	2024-05-08 10:35:28 +01:00
Kishan Dhankecha	2867ac7885	Added missing code block language in docs (#147481) ... - added language for all code blocks - replaced `bash` or `shell` with `sh` for consistency. - added `sh` and `console` in the GitHub template link generator. - updated test for GitHub template.	2024-05-01 14:44:27 +00:00
Pierre-Louis	4a65a76279	Reland: Update link branches to main (#146882) ... Reland https://github.com/flutter/flutter/pull/146558, reverted in https://github.com/flutter/flutter/pull/146880 due to an outdated test result ## Original description - Update CS and googlesource.com link branches - Update GitHub /blob/ and /tree/ links Tested links manually and fixes a few broken or deprecated links Added a test that validates that `master` isn't used, except for specified repos. Part of https://github.com/flutter/flutter/issues/121564	2024-04-17 13:16:33 +00:00
Pierre-Louis	33a9643b5d	Revert "Update link branches to main" (#146880) ... Reverts flutter/flutter#146558 Causes failure	2024-04-17 13:25:18 +02:00
Pierre-Louis	072b8874a0	Update link branches to main (#146558) ... - Update CS and googlesource.com link branches - Update GitHub /blob/ and /tree/ links Tested links manually and fixes a few broken or deprecated links Added a test that validates that `master` isn't used, except for specified repos. Part of https://github.com/flutter/flutter/issues/121564 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [Data Driven Fixes]: https://github.com/flutter/flutter/wiki/Data-driven-Fixes	2024-04-17 09:44:23 +02:00
Nate	1a0dc8f1e1	Add missing parameter to TableBorder.symmetric, and improve class constructors (#144279) ... Originally, my aim was just to refactor (as per usual), but while messing around with the `TableBorder.symmetric` constructor, I realized that `borderRadius` was missing! This pull request makes a few class constructors more efficient, and it fixes #144277 by adding the missing parameter. <br>	2024-03-04 20:20:19 +00:00
Danny Tuppeny	86613d198e	[flutter_tool] [dap] Forward Flutter progress events to DAP client (#142524) ... Builds can be slow and the legacy debug adapter would handle Flutter's `app.progress` events to update the toast notification during builds. This was lost in the new adapters - we should only a single "Launching.." notification for the whole progress. This change listens to `app.progress` events and forwards those with `finished=false` to the client if the launch progress is still active. Fixes https://github.com/Dart-Code/Dart-Code/issues/4938 https://github.com/flutter/flutter/assets/1078012/8c60cf08-e034-4a72-b31e-9c61dca388bf	2024-02-15 22:22:48 +00:00
Anis Alibegić	e063f56832	Fixed few typos (#141543) ... I continued [my mission](https://github.com/flutter/flutter/pull/141431) to find as many typos as I could. This time it's a smaller set than before. There is no need for issues since it's a typo fix.	2024-01-16 21:40:08 +00:00
Lau Ching Jun	63c58a33d7	Make handleJsonEvent public so that it can be overridden internally. (#139531)	2023-12-05 07:42:05 +00:00
Danny Tuppeny	0386f910d1	[flutter_tools/dap] Improve rendering of structured errors via DAP (#131251) ... In the legacy VS Code DAP, we would deserialise the Flutter.Error event and provide some basic colouring (eg. stack frames are faded if not from user code and the text is split between stdout/stderr to allow the client to colour it). In the new DAPs we originally used `renderedErrorText` which didn't support either of these. This change adds changes to use the structured data (with some basic parsing because the source classes are in package:flutter and not accessible here) to provide a similar experience. It would be nicer if we could use the real underlying Flutter classes for this deserialisation, but extracting them from `package:flutter` and removing all dependencies on Flutter is a much larger job and I don't think should hold up providing improved error formatting for the new DAPs. Some comparisons:  	2023-07-31 13:03:26 +01:00
Helin Shiah	0b44577f16	Add new hot reload case string (#130008) ... This change is for an internal IDE client to send a custom hot reload request, as custom requests from the client must start with `$/`. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. (this PR is linked internally) - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat	2023-07-05 15:16:33 -04:00
Danny Tuppeny	dc4541fa05	[flutter_tools] Add support for vmServiceFileInfo when attaching (#128503) ... When building the new SDK DAPs, this functionality was missed from the Flutter adapter (but added to the Dart CLI adapter). As well as passing a VM Service URI directly, we support passing a file that can be polled for it. This uses the same mechanism we use to obtain the VM Service URI from a Dart debug session (we run `dart --write-service-info=foo.json my_file.dart` and then poll that file which the VM will write) and is useful for users that have their own mechanism for launching an app (for example using custom Flutter embedders - see https://github.com/Dart-Code/Dart-Code/issues/3353) to provide a VM Service URI once the app is up and running. Fixes https://github.com/Dart-Code/Dart-Code/issues/4577.	2023-06-16 18:00:21 +00:00
Danny Tuppeny	46007d61d2	[flutter_tools] [DAP] Don't try to restart/reload if app hasn't started yet (#128267) ... The editor is set to hot-reload-on-save by default so saving while the debug session is starting currently prints an error: Failed to Hot Reload: app 'null' not found  This change skips the call to `app.restart` if the app hasn't started yet to avoid printing an error.	2023-06-09 09:41:07 +00:00
Danny Tuppeny	1a6a20cdc6	[flutter_tools] Include mode in app.start event, and forward app.start to DAP clients (#121239) ... [flutter_tools] Include mode in app.start event, and forward app.start to DAP clients	2023-04-05 05:39:09 +00:00
Michael Goderbauer	fda9ecfef7	Remove 1745 decorative breaks (#123259) ... Remove 1745 decorative breaks	2023-03-22 21:12:22 +00:00
Danny Tuppeny	3494c08448	[flutter_tools/dap] Inform DAP client whether restart is supported (#121610) ... [flutter_tools/dap] Inform DAP client whether restart is supported	2023-03-03 12:54:23 +00:00
Ben Konyi	ecd7518df5	Reland "Remove references to Observatory (#118577)" (#121606) ... This reverts commit 275ab9c69b.	2023-02-28 11:57:04 -05:00
Michael Goderbauer	275ab9c69b	Revert "Reland "Remove references to Observatory (#118577)" (#121215)" (#121555) ... Revert "Reland "Remove references to Observatory (#118577)""	2023-02-27 23:46:53 +00:00
Ben Konyi	fbae472fc3	Reland "Remove references to Observatory (#118577)" (#121215) ... This reverts commit 298d8c76ba.	2023-02-27 09:26:43 -05:00
Lioness100	26b6c1bedd	Fix typos (#121171) ... * Fix typos * lowercase animated & opacity * Undo typo fix --------- Co-authored-by: Michael Goderbauer <goderbauer@google.com>	2023-02-23 19:43:21 +00:00
Casey Hillers	298d8c76ba	Revert "Remove references to Observatory (#118577)" (#120929) ... This reverts commit 2df140f40d.	2023-02-16 21:28:30 -08:00
Christopher Fujino	c6b636fa51	[flutter_tools] Replace Future.catchError() with Future.then(onError: ...) (#120637) ... * wip run_local_linter.dart * get run_local_linter.dart working * slow working implementation * speed up run_local_linter.dart * fix run_local_linter.dart * remove catchError * another fix * fix another * fix * more fixes * fix moar * fix moar * fix * finish * fix tests * clean up further * code review * delete run_local_linter.dart	2023-02-15 19:03:00 +00:00
Ben Konyi	2df140f40d	Remove references to Observatory (#118577) ... Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags. See https://github.com/dart-lang/sdk/issues/50233	2023-02-13 14:29:30 -05:00
Danny Tuppeny	8387c2388b	[flutter_tools] Use base DAP detach and ensure correct output (#119076)	2023-02-02 13:28:12 -08:00
Danny Tuppeny	09bd0f6613	Support logging 'flutter run' communication to DAP clients (#118674) ... * Support logging 'flutter run' communication to DAP clients Fixes https://github.com/Dart-Code/Dart-Code/issues/4266. * Fix test	2023-01-19 23:50:33 +00:00
Helin Shiah	46e48ba3b4	Use program during attach if provided (#118130)	2023-01-09 11:27:47 -08:00
Danny Tuppeny	9f9010f5e8	[flutter_tools] Update DAP progress when waiting for Dart Debug extension connection (#116892) ... Fixes https://github.com/Dart-Code/Dart-Code/issues/4293.	2022-12-19 11:33:26 -05:00
Danny Tuppeny	a29796e339	[flutter_tools] Forward app.webLaunchUrl event from Flutter to DAP clients (#116275) ... * [flutter_tools] Forward app.webLaunchUrl event from Flutter to DAP clients Fixes https://github.com/Dart-Code/Dart-Code/issues/4292. * Update packages/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart Co-authored-by: Christopher Fujino <fujino@google.com> * Another static const instead of final Co-authored-by: Christopher Fujino <fujino@google.com>	2022-11-30 21:25:07 +00:00
Danny Tuppeny	51c517c03c	[flutter_tools/dap] Add support for forwarding flutter run --machine exposeUrl requests to the DAP client (#114539) ... * [flutter_tools/dap] Add support for forwarding `flutter run --machine` requests to the DAP client Currently the only request that Flutter sends to the client is `app.exposeUrl` though most of this code is generic to support other requests that may be added in future. * Improve comment * Fix thrown strings * StateError -> DebugAdapterException * Add a non-null assertion and assert * Use DebugAdapterException to handle restartRequests sent before process starts * Fix typo + use local var * Don't try to actually send Flutter messages in tests because there's no process	2022-11-09 19:16:47 +00:00
Danny Tuppeny	3b0f8335ee	[flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (#114533)	2022-11-02 18:38:46 +00:00
Danny Tuppeny	307987339e	[flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (#114369)	2022-11-02 17:07:58 +00:00
Danny Tuppeny	5655225cd7	Send progress notifications to clients during hot reload / hot restart (#112455)	2022-09-29 16:27:40 +01:00
Danny Tuppeny	676a4264aa	[dap] Don't wait for appStarted before responding to launch/attach + don't call app.stop for unstarted app (#109386)	2022-08-25 15:35:09 +00:00
Danny Tuppeny	5d31b07ed5	[flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate (#108310) ... * [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate Fixes an issue where the flutter_tester device may not be cleaned up correctly if we just terminate the Flutter process. * Update integration test expectations * Revert accidental commit	2022-07-26 10:48:38 +01:00
Danny Tuppeny	2f4299ad35	[flutter_tools] Remove unused parameter when connected DAP to VM Service (#108285) ... Since 02d9c3e6a5 this flag does absolutely nothing. The behaviour it controlled is now automatic and the flag is not required. The flag will be removed from the Dart SDK in the future after Flutter is no longer using it.	2022-07-25 18:28:12 +01:00
Danny Tuppeny	c67d2587d5	Provide more useful error message if a non-compliant DAP tool (or user) sends bad input to DAP server (#107827)	2022-07-19 11:48:05 -07:00
Danny Tuppeny	78d924af1d	[flutter_tools] [dap] Add support for passing env variables to spawned processes (#107415) ... * [flutter_tools] [dap] Add support for passing env variables to spawned processes * Use named args * Use in-memory fs and FakePlatform * Pass filesystem style to MemoryFileSystem	2022-07-12 10:04:08 +01:00
Danny Tuppeny	e2ef8cfe44	Pass app.started events to the DAP client + dart.debuggerUris for Profile mode (#106337)	2022-06-21 12:09:06 -07:00
Danny Tuppeny	147020366a	Fix issues running integration tests through DAP debug adapter (#104618) ... * Fix issues running integration tests through DAP These adapters were incorrectly trying to connect a DDS instance even when Flutter would create its own. This change disables DDS in the DAP layer and leaves it to Flutter (although it passes `--no-dds` on to Flutter if provided to the DAP process). Also fixes an issue where we would unnecessarily connect the VM Service for tests even in 'noDebug' mode because of a change/fix that now includes a 'vmServiceUri' in the `test.startedProcess` event.	2022-05-26 09:36:30 +01:00
Michael Goderbauer	d5cbb36c91	Migrate remaining files to super parameters (#101919)	2022-04-14 12:04:07 -07:00
Danny Tuppeny	675b961573	Unpause and remove breakpoints when detaching from Flutter process with DAP (#101695)	2022-04-11 21:15:37 +01:00
Michael Goderbauer	296221a90d	Partial revert of super params in tools (#101436)	2022-04-06 11:04:38 -07:00