Commit Graph

5184 Commits

Author SHA1 Message Date
Ian Hickson
21434fcf1a Refactor 'flutter drive' to get the observatory port from the logs (#7695)
This remove a very brittle aspect of flutter drive, whereby it would
assume a known port instead of explicitly finding out what it was.

Fixes #7692 and hopefully fixes the devicelab tests.
2017-01-27 01:37:28 -08:00
Ian Hickson
f888bbed48 Refactor hot/cold/drive runners a little (#7694)
Move the drive/run common stuff to RunCommandBase, rather than the
superclass which applies to everything.

Implement --no-resident (fixes
https://github.com/flutter/flutter/issues/5448). This is particularly
useful when running flutter from scripts.

Rename RunAndStayResident to ColdRunner.
2017-01-27 01:03:04 -08:00
Adam Barth
5ecf8786b4 Add ScrollView.padding (#7690)
Uses SliverPadding to implementing paddding in ScrollView. Also, deploy
ScrollView in more places now that it implements padding.

Finally, remove loader_app.dart because it is not referenced.
2017-01-26 23:14:37 -08:00
Adam Barth
9c288040ce Improve SliverBlockDelegate.estimateScrollOffsetExtent (#7689)
We now report an accurate estimate when the lastIndex is the final index
in the list.

Also, we now project forward from the lastIndex using the extent of the
reified children instead of trying to project forward from index 0.

This new algorithm leads to estimation error as you reach the end of a
list, avoiding some ballistic overscrolls.
2017-01-26 22:59:10 -08:00
Ian Hickson
a67c79a1c7 converge flutter run and flutter drive onto one behavior (#7688)
...for the port arguments
2017-01-26 21:47:14 -08:00
Ian Hickson
19d22c9726 Make devicelab count as a bot so we can see crash logs (#7687) 2017-01-26 20:17:40 -08:00
Ian Hickson
ed2be89569 Try moving from closures to direct calls. (#7679)
Rumours have it that this is faster now.

Fixes https://github.com/flutter/flutter/issues/5154
2017-01-26 18:54:48 -08:00
Adam Barth
a90e25502a Don't overshoot ballisitic scroll activities (#7670)
When we start a ballisitic scroll activity to correct an out-of-range scroll
offset, make sure we start with a velocity that is headed in the right
direction.
2017-01-26 17:26:24 -08:00
Michael Goderbauer
9f28b4ff71 Windows Fixes for Flutter Tools (#7678) 2017-01-26 17:04:53 -08:00
Ian Hickson
576b4e1179 Change --debug-port to --observatory-port (#7675)
...and add --diagnostic-port.

...and document port 0.
2017-01-26 16:42:48 -08:00
xster
682c7992e5 Fix a crash (#7597) when the flutter sdk moves after getting packages (#7601)
* Add a check in case the flutter directory in .packages no longer exists. Clean up and prompt user

* Update documentation to use flutter packages get for end-users instead of flutter update-packages.

* Merge missing sdk error with the multiple sdk error. They're really the same thing.

* Use flutterPath in both checks.

* Change file_system’s copy folder to copy director which takes into account the file system

* Test support files

* Add test and split into 2 messages again.

* Move tests to run in memory file system's copy. Tested with dev/bots/test.sh
2017-01-26 15:43:28 -08:00
Todd Volkert
8a1990ce45 Separate data_table_test util code into its own file. (#7663)
This yields a cleaner separation between common testing code
and actual tests (a distinction which is important in Google's
internal build system).
2017-01-26 12:46:28 -08:00
Todd Volkert
71242888f1 Revert method generics in packages/flutter/lib/src/http (#7662)
We converted all code to use method generics in #7235, but
we shouldn't have touched the `http` folder since this code
is pulled from upstream.
2017-01-26 12:46:00 -08:00
Michael Goderbauer
f3f2747a85 Unify engineDirs and toolsDir in Cache of Flutter Tools. (#7644)
The zip files downloaded from cloud storage are not clearly separated
into engine artifacts and tools anyways.

Also, because of this unclear separation, we were downloading
`linux-x64/artifacts.zip` twice before.
2017-01-26 10:23:52 -08:00
Ian Hickson
7c40446a69 proxy_box tests (#7658) 2017-01-26 08:00:24 -08:00
Adam Barth
a4eca31777 Use ScrollView in examples a manual_tests (#7645)
This patch deploys ScrollView in a number of demos and manual tests.
2017-01-25 21:59:03 -08:00
P.Y. Laligand
905353b4d1 Added missing dependency. (#7651) 2017-01-25 20:23:19 -08:00
Ian Hickson
46792dc2c4 Speed up hot reload in the framework. (#7647) 2017-01-25 17:54:56 -08:00
Ian Hickson
25223c75bd New scrollbars for the scrollable refactor (#7646) 2017-01-25 17:51:25 -08:00
Todd Volkert
417c2f25fc Migrate flutter_tools to use package:platform (#7642) 2017-01-25 16:06:41 -08:00
Adam Barth
600c75cb11 Viewport2 should clip visual overflow (#7641)
When you put a box in a Viewport2, it might paint outside its allocated bounds.
This patch teaches Viewport2 to clip when that happens.
2017-01-25 15:54:46 -08:00
Ian Hickson
9ff2e978cd Sliver Padding (#7628) 2017-01-25 15:00:57 -08:00
Hans Muller
9cfcd3fdec Corrected the "Routes can return a value" example (#7638) 2017-01-25 15:00:18 -08:00
Ian Hickson
1426ef9944 Appbar slivers. (#7631) 2017-01-25 13:18:57 -08:00
Adam Barth
eba5fb1a18 Add a sliver-based ScrollView (#7627)
This patch introduces ScrollView, which is a convenience widget for using a
SliverBlock. This patch also switches a number of tests from Block to
ScrollView. Once we support more features of block (e.g., padding and
shrinkwrapping), we'll be able to move over more clients.
2017-01-25 12:51:22 -08:00
xster
ee97e5639e Change file system copy folder to copy directory (#7624)
* Change file_system’s copy folder to copy director which takes into account the file system

* Address review comments.
Test with 2 different instances of file systems.
2017-01-25 11:41:48 -08:00
Michael Goderbauer
9733aab929 Fix broken device test (#7637) 2017-01-25 11:25:07 -08:00
Adam Barth
0eb8f94b1c Fix display list harness diagnostics (#7634) 2017-01-25 10:08:11 -08:00
Hans Muller
e5aa1b1e4e Added PageRouteBuilder (#7632) 2017-01-25 08:50:30 -08:00
Ian Hickson
94fab77bea More docs updates for services. (#7633) 2017-01-24 23:34:16 -08:00
Ian Hickson
6bd578ff52 Reword the SystemChrome docs to be in the Flutter voice and style. (#7599) 2017-01-24 23:29:33 -08:00
Michael Goderbauer
c47069a6b1 Tiny improvement to flutter doctor output on Windows. (#7629)
Follow-up to #7625
2017-01-24 17:29:06 -08:00
Michael Goderbauer
aaaf0dac19 Teach Flutter Tools about IntelliJ and Android SDK on Windows. (#7622)
Required for https://github.com/flutter/flutter/issues/138
2017-01-24 16:53:20 -08:00
Ian Hickson
58348612a3 Factor out debugPaintPadding and test it (#7598)
I plan to use this to implement similar logic in SliverPadding.

To make this easier to test I extended the paints matcher to accept a
function that takes a canvas. While I was at it I also made it accept
a Finder, it'll go and find the render object for you.

Also added support for paints..path and fixed some grammar in the
error messages.

Also improved the docs for debugPaint*.
2017-01-24 16:08:27 -08:00
Adam Barth
559621ca5a Add SingleChildScrollView (#7620)
This widget is a replacement for ScrollableViewport that uses the new
Scrollable2 machinery. The widget is not based on Slivers but does use the new
scroll behavior classes.
2017-01-24 15:16:01 -08:00
Ian Hickson
f683abd757 Sliver Block (#7618) 2017-01-24 15:06:53 -08:00
Hans Muller
8c5bee9405 Add Navigator.pushReplacement() and Navigator.pushReplacementNamed() (#7611) 2017-01-24 11:36:48 -08:00
Ian Hickson
1bdf351818 Merge pubspec.yaml and flutter.yaml. (#7605) 2017-01-24 11:19:31 -08:00
Todd Volkert
9ba607862e Update to package:process v1.0.1 (#7607) 2017-01-24 10:09:29 -08:00
Adam Barth
a3a70c6b23 Fix flutter tool (#7609)
We need to pin `package:process` because version 1.0.1 contains a breaking
change to the package's API.
2017-01-24 09:46:36 -08:00
Adam Barth
134096022c Test PaginatedDataTable (#7594)
This patch contains some basic tests for PaginatedDataTable.
2017-01-23 21:36:42 -08:00
Yegor
4bec9cd940 update build benchmark to match #7589 (#7600) 2017-01-23 17:49:01 -08:00
Devon Carew
a6777b2a60 remove flutter setup (#7596) 2017-01-23 15:22:16 -08:00
Hans Muller
44f957d606 Prevent overlapping hero transitions from starting (#7568) 2017-01-23 14:52:32 -08:00
Ian Hickson
a34ae0f99d Talk about how to resize IconButtons more. (#7595)
Answers http://stackoverflow.com/questions/41729278/why-is-this-icon-being-clipped
2017-01-23 14:42:30 -08:00
James Robinson
6c5974fd5f [gn] Update flutter_tools GN build (#7592)
This package depends on package:process now.
2017-01-23 13:46:37 -08:00
Ian Hickson
84c0b34782 Test some of the sliver helper classes (#7574) 2017-01-23 13:36:44 -08:00
Ryan Macnak
76460967e6 Adapt to refactoring of snapshot APIs in the Dart VM. (#7589) 2017-01-23 13:28:35 -08:00
Adam Barth
bf296f715e Test DataTable (#7591)
This patch adds a basic test for the DataTable widget.
2017-01-23 12:40:51 -08:00
Ian Hickson
94cac1a69c flutter test --start-paused (#7584)
Make debugging tests in a debugger easier.

Fixes https://github.com/flutter/flutter/issues/163
2017-01-23 11:31:59 -08:00